Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: blimp/common/proto/settings.proto

Issue 1810213009: blimp: Add settings to allow the client to download the whole page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@record_full_document
Patch Set: Minor comment fixes. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/common/proto/settings.proto
diff --git a/blimp/common/proto/settings.proto b/blimp/common/proto/settings.proto
new file mode 100644
index 0000000000000000000000000000000000000000..17b25f393498e8ae7d92ffc5ec4b6c52ab7b3489
--- /dev/null
+++ b/blimp/common/proto/settings.proto
@@ -0,0 +1,20 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+syntax = "proto2";
+
+option optimize_for = LITE_RUNTIME;
+
+package blimp;
+
+// This includes any settings/flags that can be set on the client or the engine.
+message SettingsMessage {
+ optional EngineSettingsMessage engine_settings = 1;
+}
+
+// Client ==> Engine Settings
+message EngineSettingsMessage {
haibinlu 2016/03/22 17:28:39 you can put record_whole_document directly in Sett
Khushal 2016/03/25 23:00:22 I was putting it in EngineSettingsMessage so in ca
+ // -----------------------Web Preferences----------------------
+ optional bool record_whole_document = 1;
+}

Powered by Google App Engine
This is Rietveld 408576698