blimp/common/proto/settings.proto - Issue 1810213009: blimp: Add settings to allow the client to download the whole page.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/common/proto/settings.proto

Issue 1810213009: blimp: Add settings to allow the client to download the whole page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@record_full_document

Patch Set: Minor comment fixes. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 syntax = "proto2";

	6

	7 option optimize_for = LITE_RUNTIME;

	8

	9 package blimp;

	10

	11 // This includes any settings/flags that can be set on the client or the engine.

	12 message SettingsMessage {

	13 optional EngineSettingsMessage engine_settings = 1;

	14 }

	15

	16 // Client ==> Engine Settings

	17 message EngineSettingsMessage {
	haibinlu 2016/03/22 17:28:39 you can put record_whole_document directly in Sett you can put record_whole_document directly in SettingsMessage, and remove EngineSettingsMessage Khushal 2016/03/25 23:00:22 I was putting it in EngineSettingsMessage so in ca Show quoted text On 2016/03/22 17:28:39, haibinlu wrote: > you can put record_whole_document directly in SettingsMessage, and remove > EngineSettingsMessage I was putting it in EngineSettingsMessage so in case we add settings that go from the engine to client, they can distinctly be added here. You think it would be better if it were in a single message?
	18 // -----------------------Web Preferences----------------------

	19 optional bool record_whole_document = 1;

	20 }

OLD	NEW

« blimp/client/feature/settings_feature.cc ('K') | « blimp/common/proto/blimp_message.proto ('k') | blimp/engine/BUILD.gn » ('j') | blimp/engine/feature/engine_render_widget_feature.cc » ('J')