blimp/client/session/blimp_client_session.h - Issue 1810213009: blimp: Add settings to allow the client to download the whole page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/session/blimp_client_session.h

Issue 1810213009: blimp: Add settings to allow the client to download the whole page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@record_full_document

Patch Set: Minor comment fixes. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/feature/settings_feature.cc ('K') | « blimp/client/feature/settings_feature.cc ('k') | blimp/client/session/blimp_client_session.cc » ('j') | blimp/common/proto/settings.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/session/blimp_client_session.h

diff --git a/blimp/client/session/blimp_client_session.h b/blimp/client/session/blimp_client_session.h

index d7ffa56510b7679c0d966f13b5bd866ff22371cc..627f986dc2285a0106b8c5763b0191533126a719 100644

--- a/blimp/client/session/blimp_client_session.h

+++ b/blimp/client/session/blimp_client_session.h

@@ -33,6 +33,7 @@ namespace client {

class ClientNetworkComponents;

class NavigationFeature;

class RenderWidgetFeature;

+class SettingsFeature;

class TabControlFeature;

class NetworkEventObserver {

@@ -90,6 +91,7 @@ class BLIMP_CLIENT_EXPORT BlimpClientSession : public NetworkEventObserver {

scoped_ptr<TabControlFeature> tab_control_feature_;

scoped_ptr<NavigationFeature> navigation_feature_;

scoped_ptr<RenderWidgetFeature> render_widget_feature_;

+ scoped_ptr<SettingsFeature> settings_feature_;

// The AssignmentSource is used when the user of BlimpClientSession calls

// Connect() to get a valid assignment and later connect to the engine.