Issue 181006: Make the default ok/cancel button come from the pak files....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 181006: Make the default ok/cancel button come from the pak files.... (Closed)

Created:
11 years, 3 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, John Grabowski, Pam (message me for reviews), Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make the default ok/cancel button come from the pak files. BUG=20496 TEST=more alerts should get localized strings. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24752

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	chrome/browser/app_modal_dialog_mac.mm	View		3 chunks	+6 lines, -8 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 3 months ago (2009-08-28 18:16:04 UTC) #2

L
G
T
M

http://codereview.chromium.org/181006/diff/1/2
File chrome/browser/app_modal_dialog_mac.mm (right):

http://codereview.chromium.org/181006/diff/1/2#newcode13
Line 13: #include "grit/app_strings.h"
sortile

Expand Messages | Collapse Messages