Fix shelf overflow bubble position

ash/shelf/overflow_bubble_view.cc

Index: ash/shelf/overflow_bubble_view.cc
diff --git a/ash/shelf/overflow_bubble_view.cc b/ash/shelf/overflow_bubble_view.cc
index ff0f2c38885d5d17ad929e546350a0d7bd98bdd8..6573de0d550549d56bf98073463fa5e534b3a9d8 100644
--- a/ash/shelf/overflow_bubble_view.cc
+++ b/ash/shelf/overflow_bubble_view.cc
@@ -38,6 +38,9 @@ OverflowBubbleView::~OverflowBubbleView() {}
 
 void OverflowBubbleView::InitOverflowBubble(views::View* anchor,
                                             ShelfView* shelf_view) {
+  shelf_view_ = shelf_view;
+  AddChildView(shelf_view_);
+
   SetAnchorView(anchor);
   set_arrow(GetBubbleArrow());

[Greg Levin, 2016/03/17 17:41:39]

GetBubbleArrow() depends on having access to shelf view.  Prior to
https://codereview.chromium.org/1659283002/diff/80001/ash/shelf/overflow_bubb...
SetAnchorView() was sufficient to provide access to shelf view; that change
switched to using shelf_view_ in GetBubbleArrow(), which was still NULL at this
point.  No shelf view -> no arrow -> wrong bubble placement for vertical
shelves.

   set_background(NULL);
@@ -52,9 +55,6 @@ void OverflowBubbleView::InitOverflowBubble(views::View* anchor,
   layer()->SetFillsBoundsOpaquely(false);
   layer()->SetMasksToBounds(true);
 
-  shelf_view_ = shelf_view;
-  AddChildView(shelf_view_);
-
   set_parent_window(Shell::GetContainer(
       anchor->GetWidget()->GetNativeWindow()->GetRootWindow(),
       kShellWindowId_ShelfBubbleContainer));