Fix pessimizing move in SamplePictFile

Fix pessimizing move in SamplePictFile

../../samplecode/SamplePictFile.cpp:194:20: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
            return std::move(pic);
                               ^

R=reed@google.com,mtklein@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1809943005

Committed: https://skia.googlesource.com/skia/+/3e33e6f57685beeb7f5449aee8694d539e4c5a6f

[f(malita), 2016-03-18 17:43:42]

Description was changed from

==========
Fix pessimizing move in SamplePictFile

../../samplecode/SamplePictFile.cpp:194:20: error: moving a local object in a
return statement prevents copy elision [-Werror,-Wpessimizing-move]
            return std::move(pic);
                               ^

R=reed@google.com,mtklein@google.com
==========

to

==========
Fix pessimizing move in SamplePictFile

../../samplecode/SamplePictFile.cpp:194:20: error: moving a local object in a
return statement prevents copy elision [-Werror,-Wpessimizing-move]
            return std::move(pic);
                               ^

R=reed@google.com,mtklein@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[f(malita), 2016-03-18 17:45:44]

Interesting that we don't hit this on the bots.

Do we not have -Wpessimizing-move turned on?  Or maybe it's my local clang
version (3.7.0).

[f(malita), 2016-03-18 17:45:48]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-03-18 17:45:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809943005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809943005/1

[commit-bot: I haz the power, 2016-03-18 17:45:51]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-03-18 23:45 UTC

[mtklein, 2016-03-18 18:05:42]

lgtm

Boy I wish we didn't also have to think about RVO / NRVO when thinking about
rvalue references...

I do believe -Wpessimizing-move was added in Clang 3.7.  We have some bots
running that, some bots running earlier Clangs, and some bots running later
Clangs.  That does make it a little tricky to turn on, except through something
generic like -Wall or -Wextra (both already on), or if you're brave,
-Weverything and many new -Wno-foo and -Wno-bar.

[commit-bot: I haz the power, 2016-03-18 18:07:52]

Description was changed from

==========
Fix pessimizing move in SamplePictFile

../../samplecode/SamplePictFile.cpp:194:20: error: moving a local object in a
return statement prevents copy elision [-Werror,-Wpessimizing-move]
            return std::move(pic);
                               ^

R=reed@google.com,mtklein@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix pessimizing move in SamplePictFile

../../samplecode/SamplePictFile.cpp:194:20: error: moving a local object in a
return statement prevents copy elision [-Werror,-Wpessimizing-move]
            return std::move(pic);
                               ^

R=reed@google.com,mtklein@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/3e33e6f57685beeb7f5449aee8694d539e4c5a6f
==========

[commit-bot: I haz the power, 2016-03-18 18:07:53]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3e33e6f57685beeb7f5449aee8694d539e4c5a6f