samplecode/SamplePictFile.cpp - Issue 1809943005: Fix pessimizing move in SamplePictFile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samplecode/SamplePictFile.cpp

Issue 1809943005: Fix pessimizing move in SamplePictFile (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samplecode/SamplePictFile.cpp

diff --git a/samplecode/SamplePictFile.cpp b/samplecode/SamplePictFile.cpp

index ae107969013fe0d4582ce209ddddfefa3c4e7cdc..b456aef1bfd7ae49be391df679e83cd83f0668c0 100644

--- a/samplecode/SamplePictFile.cpp

+++ b/samplecode/SamplePictFile.cpp

@@ -191,7 +191,7 @@ private:

switch (bbox) {

case kNo_BBoxType:

// no bbox playback necessary

- return std::move(pic);

+ return pic;

case kRTree_BBoxType:

factory.reset(new SkRTreeFactory);

break;

« no previous file with comments | « no previous file | no next file » | no next file with comments »