ui/views/bubble/bubble_frame_view.h - Issue 1809933003: Port BubbleDelegate tests to BubbleDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/bubble_frame_view.h

Issue 1809933003: Port BubbleDelegate tests to BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/bubble/bubble_frame_view.h

diff --git a/ui/views/bubble/bubble_frame_view.h b/ui/views/bubble/bubble_frame_view.h

index f9d3f30e4ae2e57a6fa193f6a36fb6a71c3efb68..7b10ca038336cdb6f983eea4ab3856478c1cb016 100644

--- a/ui/views/bubble/bubble_frame_view.h

+++ b/ui/views/bubble/bubble_frame_view.h

@@ -92,6 +92,7 @@ class VIEWS_EXPORT BubbleFrameView : public NonClientFrameView,

private:

FRIEND_TEST_ALL_PREFIXES(BubbleFrameViewTest, GetBoundsForClientView);

FRIEND_TEST_ALL_PREFIXES(BubbleDelegateTest, CloseReasons);

+ FRIEND_TEST_ALL_PREFIXES(BubbleDialogDelegateTest, CloseReasons);

msw 2016/03/17 17:28:26 Can you expose more functions in the Test* subclas

Evan Stade 2016/03/17 22:41:34 this is just for access to close_, and there's no

// Mirrors the bubble's arrow location on the |vertical| or horizontal axis,

// if the generated window bounds don't fit in the monitor bounds.