Port BubbleDelegate tests to BubbleDialogDelegate

ui/views/bubble/bubble_frame_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_BUBBLE_BUBBLE_FRAME_VIEW_H_
 #define UI_VIEWS_BUBBLE_BUBBLE_FRAME_VIEW_H_
 
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
@@ skipping 74 matching lines @@
  protected:
   // Returns the available screen bounds if the frame were to show in |rect|.
   virtual gfx::Rect GetAvailableScreenBounds(const gfx::Rect& rect) const;
 
   bool IsCloseButtonVisible() const;
   gfx::Rect GetCloseButtonMirroredBounds() const;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(BubbleFrameViewTest, GetBoundsForClientView);
   FRIEND_TEST_ALL_PREFIXES(BubbleDelegateTest, CloseReasons);
+  FRIEND_TEST_ALL_PREFIXES(BubbleDialogDelegateTest, CloseReasons);

[msw, 2016/03/17 17:28:26]

Can you expose more functions in the Test* subclasses to avoid friend tests?

[Evan Stade, 2016/03/17 22:41:34]

this is just for access to close_, and there's no test bubble frame view to
expose close_ to. If it makes you feel better the BubbleDelegateTest one will go
away one day.

 
   // Mirrors the bubble's arrow location on the |vertical| or horizontal axis,
   // if the generated window bounds don't fit in the monitor bounds.
   void MirrorArrowIfOffScreen(bool vertical,
                               const gfx::Rect& anchor_rect,
                               const gfx::Size& client_size);
 
   // Adjust the bubble's arrow offsets if the generated window bounds don't fit
   // in the monitor bounds.
   void OffsetArrowIfOffScreen(const gfx::Rect& anchor_rect,
@@ skipping 21 matching lines @@
 
   // Whether the close button was clicked.
   bool close_button_clicked_;
 
   DISALLOW_COPY_AND_ASSIGN(BubbleFrameView);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_BUBBLE_BUBBLE_FRAME_VIEW_H_