Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 1809863002: Update some callers to use more direct ways of constructing IPAddress from well known literals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/ip_address_unittest.cc ('k') | net/http/http_server_properties_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index bc7f7b37dfbf3d0f33dac274a581e2aad2f2e157..221eb4659cedc39b8a2c183f6361ed0b9bf144dd 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -12912,9 +12912,7 @@ TEST_P(HttpNetworkTransactionTest, UseIPConnectionPooling) {
MockRead(ASYNC, 0, 6),
};
- IPAddress ip;
- ASSERT_TRUE(ip.AssignFromIPLiteral("127.0.0.1"));
- IPEndPoint peer_addr = IPEndPoint(ip, 443);
+ auto peer_addr = IPEndPoint(IPAddress::IPv4Localhost(), 443);
Ryan Hamilton 2016/03/17 00:28:37 How about: IPEndPoint peer_addr(IPAddress::IPv4Lo
eroman 2016/03/17 01:01:19 Done.
MockConnect connect(ASYNC, OK, peer_addr);
SequencedSocketData spdy_data(connect, spdy_reads, arraysize(spdy_reads),
spdy_writes, arraysize(spdy_writes));
@@ -13012,9 +13010,7 @@ TEST_P(HttpNetworkTransactionTest, UseIPConnectionPoolingAfterResolution) {
MockRead(ASYNC, 0, 6),
};
- IPAddress ip;
- ASSERT_TRUE(ip.AssignFromIPLiteral("127.0.0.1"));
- IPEndPoint peer_addr = IPEndPoint(ip, 443);
+ auto peer_addr = IPEndPoint(IPAddress::IPv4Localhost(), 443);
MockConnect connect(ASYNC, OK, peer_addr);
SequencedSocketData spdy_data(connect, spdy_reads, arraysize(spdy_reads),
spdy_writes, arraysize(spdy_writes));
@@ -13143,9 +13139,7 @@ TEST_P(HttpNetworkTransactionTest,
MockRead(ASYNC, 0, 6),
};
- IPAddress ip;
- ASSERT_TRUE(ip.AssignFromIPLiteral("127.0.0.1"));
- IPEndPoint peer_addr = IPEndPoint(ip, 443);
+ auto peer_addr = IPEndPoint(IPAddress::IPv4Localhost(), 443);
MockConnect connect(ASYNC, OK, peer_addr);
SequencedSocketData spdy_data(connect, spdy_reads, arraysize(spdy_reads),
spdy_writes, arraysize(spdy_writes));
« no previous file with comments | « net/base/ip_address_unittest.cc ('k') | net/http/http_server_properties_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698