Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: net/base/ip_address_unittest.cc

Issue 1809863002: Update some callers to use more direct ways of constructing IPAddress from well known literals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/ip_address_unittest.cc
diff --git a/net/base/ip_address_unittest.cc b/net/base/ip_address_unittest.cc
index dffb905efead884f313331ff9ec23cd18d3cbf1d..2863c6b31a02f16b683e65d7e2618b84fcafc382 100644
--- a/net/base/ip_address_unittest.cc
+++ b/net/base/ip_address_unittest.cc
@@ -82,6 +82,16 @@ TEST(IPAddressTest, IsZero) {
EXPECT_FALSE(empty_address.IsZero());
}
+TEST(IPAddressTest, AllZeros) {
+ EXPECT_TRUE(IPAddress::AllZeros(0).empty());
+
+ EXPECT_EQ(3u, IPAddress::AllZeros(3).size());
+ EXPECT_TRUE(IPAddress::AllZeros(3).IsZero());
+
+ EXPECT_EQ("0.0.0.0", IPAddress::IPv4AllZeros().ToString());
+ EXPECT_EQ("::", IPAddress::IPv6AllZeros().ToString());
+}
+
TEST(IPAddressTest, ToString) {
uint8_t addr1[4] = {0, 0, 0, 0};
IPAddress ip_address1(addr1);

Powered by Google App Engine
This is Rietveld 408576698