Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1809833002: [chromedriver] Retry screenshots on Android. (Closed)

Created:
4 years, 9 months ago by samuong
Modified:
4 years, 9 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Retry screenshots on Android. Previously only desktop screenshots were retried. This works around some flakiness we've observed in recent versions of Chrome for Android. More context (for Googlers only, sorry) is available at b/27644687. BUG= TBR=stgao@chromium.org Committed: https://crrev.com/32c891c5de9c7f7bc1aa956b1fbff04cfe8dc768 Cr-Commit-Position: refs/heads/master@{#381808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/test/chromedriver/window_commands.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
samuong
4 years, 9 months ago (2016-03-16 19:42:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809833002/1
4 years, 9 months ago (2016-03-17 21:28:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 22:28:56 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/32c891c5de9c7f7bc1aa956b1fbff04cfe8dc768 Cr-Commit-Position: refs/heads/master@{#381808}
4 years, 9 months ago (2016-03-17 22:30:56 UTC) #10
stgao
4 years, 9 months ago (2016-03-18 16:34:14 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698