Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: chrome/test/chromedriver/window_commands.cc

Issue 1809833002: [chromedriver] Retry screenshots on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/window_commands.cc
diff --git a/chrome/test/chromedriver/window_commands.cc b/chrome/test/chromedriver/window_commands.cc
index ff0be7fa2c2e8505d49f6d99f16f715a51593886..abe73afaa7dba3180ff174181d9bd4eab8852f6b 100644
--- a/chrome/test/chromedriver/window_commands.cc
+++ b/chrome/test/chromedriver/window_commands.cc
@@ -852,13 +852,13 @@ Status ExecuteScreenshot(
if (status.IsError())
return status;
status = extension->CaptureScreenshot(&screenshot);
- if (status.IsError()) {
- LOG(WARNING) << "screenshot failed with extension, fallback to DevTools";
- status = web_view->CaptureScreenshot(&screenshot);
- }
} else {
status = web_view->CaptureScreenshot(&screenshot);
}
+ if (status.IsError()) {
+ LOG(WARNING) << "screenshot failed, retrying";
+ status = web_view->CaptureScreenshot(&screenshot);
+ }
if (status.IsError())
return status;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698