Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: ui/views/widget/desktop_aura/x11_desktop_handler.cc

Issue 180983002: Avoids releasing capture prematurily when dragging tabs from one to another browser window (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Avoids releasing capture prematurily when dragging tabs from one browser window to another Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/desktop_aura/x11_desktop_handler.cc
diff --git a/ui/views/widget/desktop_aura/x11_desktop_handler.cc b/ui/views/widget/desktop_aura/x11_desktop_handler.cc
index d98dfa644354d2590d7e42c20e4eb52eaa68fdd2..66da0600ee47883b84f2516f6dc211dd25d61ed3 100644
--- a/ui/views/widget/desktop_aura/x11_desktop_handler.cc
+++ b/ui/views/widget/desktop_aura/x11_desktop_handler.cc
@@ -92,9 +92,10 @@ void X11DesktopHandler::ActivateWindow(::Window window) {
// the X server to do that. Note that the call will raise an X error if the
// window is not mapped.
XSetInputFocus(xdisplay_, window, RevertToParent, CurrentTime);
-
- OnActiveWindowChanged(window);
}
+ // Notify synchronously in order to maintain focus on a correct view when
+ // activation changes.
+ OnActiveWindowChanged(window);
varkha 2014/02/26 20:30:18 Without this when a tab that is dragged from one b
Elliot Glaysher 2014/02/26 20:33:17 Not that I know of. sadrul@ might be a better pers
}
void X11DesktopHandler::DeactivateWindow(::Window window) {

Powered by Google App Engine
This is Rietveld 408576698