chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc - Issue 180983002: Avoids releasing capture prematurily when dragging tabs from one to another browser window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

Issue 180983002: Avoids releasing capture prematurily when dragging tabs from one to another browser window (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Avoids releasing capture prematurily when dragging tabs from one browser window to another Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/tabs/tab_drag_controller.cc ('K') | « chrome/browser/ui/views/tabs/tab_drag_controller.cc ('k') | ui/views/widget/desktop_aura/x11_desktop_handler.cc » ('j') | ui/views/widget/desktop_aura/x11_desktop_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

index 18b043bebc78f2426d143a9a726a295cc64d8ca7..cbb65b3ccb242ddb199d3f4342fc717ce287f300 100644

--- a/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

+++ b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc

@@ -325,7 +325,6 @@ IN_PROC_BROWSER_TEST_F(TabDragControllerTest, GestureEndShouldEndDragTest) {

AddTabAndResetBrowser(browser());

TabStrip* tab_strip = GetTabStripForBrowser(browser());

- TabStripModel* model = browser()->tab_strip_model();

Tab* tab1 = tab_strip->tab_at(1);

gfx::Point tab_1_center(tab1->width() / 2, tab1->height() / 2);