Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 180973006: Merge 252421 "net: don't always add TLS padding." (Closed)

Created:
6 years, 9 months ago by agl
Modified:
6 years, 9 months ago
Reviewers:
agl, wtc
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Merge 252421 "net: don't always add TLS padding." > net: don't always add TLS padding. > > In order to flush out any problems with padding, Chrome has always been > adding it, even when the ClientHello was small enough not to need it. > > Since that change is in Chrome 33 (and the Chrome 34 branch), it's time > to remove it. > > BUG=315828 > > Review URL: https://codereview.chromium.org/171713011 TBR=agl@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -36 lines) Patch
M net/third_party/nss/README.chromium View 1 chunk +0 lines, -3 lines 0 comments Download
M net/third_party/nss/patches/applypatches.sh View 1 chunk +0 lines, -2 lines 0 comments Download
D net/third_party/nss/patches/paddingextensionall.patch View 1 chunk +0 lines, -25 lines 0 comments Download
M net/third_party/nss/ssl/ssl3ext.c View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
agl
6 years, 9 months ago (2014-02-27 16:15:14 UTC) #1
agl
Committed patchset #1 manually as r253838 (tree was closed).
6 years, 9 months ago (2014-02-27 16:17:05 UTC) #2
wtc
6 years, 9 months ago (2014-02-27 17:22:18 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698