Issue 171713011: net: don't always add TLS padding.

Issue 171713011: net: don't always add TLS padding. (Closed)

Created:
6 years, 10 months ago by agl

Modified:
6 years, 10 months ago

Reviewers:
wtc

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, Ryan Sleevi

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

net: don't always add TLS padding. In order to flush out any problems with padding, Chrome has always been adding it, even when the ClientHello was small enough not to need it. Since that change is in Chrome 33 (and the Chrome 34 branch), it's time to remove it. BUG=315828 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252421

Patch Set 1 #

Total comments: 2

Patch Set 2 : Also remove from README. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -36 lines)			Patch
M	net/third_party/nss/README.chromium	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/third_party/nss/patches/applypatches.sh	View		1 chunk	+0 lines, -2 lines	0 comments	Download
D	net/third_party/nss/patches/paddingextensionall.patch	View		1 chunk	+0 lines, -25 lines	0 comments	Download
M	net/third_party/nss/ssl/ssl3ext.c	View		2 chunks	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

wtc

Patch set 1 LGTM. We probably should mark bug 315828 as fixed in M-33. https://codereview.chromium.org/171713011/diff/1/net/third_party/nss/patches/applypatches.sh ...

6 years, 10 months ago (2014-02-20 18:51:28 UTC) #2

agl

https://codereview.chromium.org/171713011/diff/1/net/third_party/nss/patches/applypatches.sh File net/third_party/nss/patches/applypatches.sh (left): https://codereview.chromium.org/171713011/diff/1/net/third_party/nss/patches/applypatches.sh#oldcode40 net/third_party/nss/patches/applypatches.sh:40: patch -p4 < $patches_dir/paddingextensionall.patch On 2014/02/20 18:51:29, wtc wrote: ...

6 years, 10 months ago (2014-02-20 20:19:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/171713011/50001

6 years, 10 months ago (2014-02-20 21:06:15 UTC) #6

Message was sent while issue was closed.

Change committed as 252421

Expand Messages | Collapse Messages