Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1809643004: PPC: Simulator fixes for shift operations. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Simulator fixes for shift operations. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/dddb12c4d67ec0ffd198d598a263436cd84f8e35 Cr-Commit-Position: refs/heads/master@{#34837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/ppc/simulator-ppc.cc View 6 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-16 18:29:24 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809643004/1
4 years, 9 months ago (2016-03-16 18:29:36 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 18:49:51 UTC) #5
john.yan
lgtm
4 years, 9 months ago (2016-03-16 19:04:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809643004/1
4 years, 9 months ago (2016-03-16 19:13:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 19:14:55 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 19:16:11 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dddb12c4d67ec0ffd198d598a263436cd84f8e35
Cr-Commit-Position: refs/heads/master@{#34837}

Powered by Google App Engine
This is Rietveld 408576698