Fix support for accessible action verbs and performing the default action.

Fix support for accessible action verbs and performing the default action.

Accessible objects support a "default action" if something happens when
you click on them. On some platforms we return a localized string like
"press" or "uncheck" indicating what action will occur. This change fixes
a few cases that weren't correct:

1. A few objects had actions but no verb - fix this by adding a verb for
   pop-up buttons ("open") and a default verb when nothing else applies
   ("click").

2. Ensure we always return an action verb when an object has a default
   action, and never otherwise.

3. Fix detection of click event listeners - we were using an API that
   only returned some; use the right API to get all click-and-mouse-related
   event listeners, but exclude the HTML BODY element because lots of
   pages have click listeners there and they're rarely what we want.

4. The Windows API accDoDefaultAction should return an error if called on
   an object with no default action.

BUG=595222
Committed: https://crrev.com/30fc95f3dd93562d7be852205c49bd49e793d84c
Cr-Commit-Position: refs/heads/master@{#381911}

[dmazzoni, 2016-03-16 16:43:29]

dmazzoni@chromium.org changed reviewers:
+ jochen@chromium.org, nektar@chromium.org

[dmazzoni, 2016-03-16 16:43:29]

jochen: OWNERS review for third_party/WebKit/public and content/
nektar: primary review

[nektarios, 2016-03-16 17:44:47]

lgtm

[nektarios, 2016-03-16 17:45:22]

Shouldn't popupButtonRole also have the action of "press"?

[dmazzoni, 2016-03-16 17:49:42]

On 2016/03/16 17:45:22, nektarios wrote:
> Shouldn't popupButtonRole also have the action of "press"?

I couldn't decide. I chose "open" since it opens the pop-up, rather than taking
some action

[blink-reviews, 2016-03-16 17:57:14]

So, both popupButtonRole and popupButtonMenuList have the same action?

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2016-03-16 17:57:14]

So, both popupButtonRole and popupButtonMenuList have the same action?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-03-16 18:48:30]

menuListPopupRole was a mistake. It's not a control, it's the role for the
container that the pop-up menu lives in. It doesn't have a default action
so I deleted it from that function.

On Wed, Mar 16, 2016 at 10:57 AM 'Nektarios Paisios' via Chromium-reviews <
chromium-reviews@chromium.org> wrote:

> So, both popupButtonRole and popupButtonMenuList have the same action?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-03-16 18:48:31]

menuListPopupRole was a mistake. It's not a control, it's the role for the
container that the pop-up menu lives in. It doesn't have a default action
so I deleted it from that function.

On Wed, Mar 16, 2016 at 10:57 AM 'Nektarios Paisios' via Chromium-reviews <
chromium-reviews@chromium.org> wrote:

> So, both popupButtonRole and popupButtonMenuList have the same action?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jochen (gone - plz use gerrit), 2016-03-17 19:59:48]

lgtm

[dmazzoni, 2016-03-18 06:14:52]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-03-18 06:14:52]

The patchset sent to the CQ was uploaded after l-g-t-m from nektar@chromium.org
Link to the patchset: https://codereview.chromium.org/1809573003/#ps20001
(title: "Fix two tests")

[commit-bot: I haz the power, 2016-03-18 06:15:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809573003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809573003/20001

[commit-bot: I haz the power, 2016-03-18 08:28:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-18 08:30:13]

Description was changed from

==========
Fix support for accessible action verbs and performing the default action.

Accessible objects support a "default action" if something happens when
you click on them. On some platforms we return a localized string like
"press" or "uncheck" indicating what action will occur. This change fixes
a few cases that weren't correct:

1. A few objects had actions but no verb - fix this by adding a verb for
   pop-up buttons ("open") and a default verb when nothing else applies
   ("click").

2. Ensure we always return an action verb when an object has a default
   action, and never otherwise.

3. Fix detection of click event listeners - we were using an API that
   only returned some; use the right API to get all click-and-mouse-related
   event listeners, but exclude the HTML BODY element because lots of
   pages have click listeners there and they're rarely what we want.

4. The Windows API accDoDefaultAction should return an error if called on
   an object with no default action.

BUG=595222
==========

to

==========
Fix support for accessible action verbs and performing the default action.

Accessible objects support a "default action" if something happens when
you click on them. On some platforms we return a localized string like
"press" or "uncheck" indicating what action will occur. This change fixes
a few cases that weren't correct:

1. A few objects had actions but no verb - fix this by adding a verb for
   pop-up buttons ("open") and a default verb when nothing else applies
   ("click").

2. Ensure we always return an action verb when an object has a default
   action, and never otherwise.

3. Fix detection of click event listeners - we were using an API that
   only returned some; use the right API to get all click-and-mouse-related
   event listeners, but exclude the HTML BODY element because lots of
   pages have click listeners there and they're rarely what we want.

4. The Windows API accDoDefaultAction should return an error if called on
   an object with no default action.

BUG=595222

Committed: https://crrev.com/30fc95f3dd93562d7be852205c49bd49e793d84c
Cr-Commit-Position: refs/heads/master@{#381911}
==========

[commit-bot: I haz the power, 2016-03-18 08:30:15]

Patchset 2 (id:??) landed as
https://crrev.com/30fc95f3dd93562d7be852205c49bd49e793d84c
Cr-Commit-Position: refs/heads/master@{#381911}