third_party/WebKit/Source/modules/accessibility/AXObject.cpp - Issue 1809573003: Fix support for accessible action verbs and performing the default action.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Issue 1809573003: Fix support for accessible action verbs and performing the default action. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix two tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXObject.h ('k') | third_party/WebKit/public/platform/WebLocalizedString.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

index 5a2abc3cd1a38e4acf70a72b2f06409e7084b220..9bd7ce182df5201a8d8461b3e42f9782547e5ece 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

@@ -917,7 +917,8 @@ static String queryString(WebLocalizedString::Name name)

String AXObject::actionVerb() const

{

- // FIXME: Need to add verbs for select elements.

+ if (!actionElement())

+ return emptyString();

switch (roleValue()) {

case ButtonRole:

@@ -933,13 +934,9 @@ String AXObject::actionVerb() const

case LinkRole:

return queryString(WebLocalizedString::AXLinkActionVerb);

case PopUpButtonRole:

- // FIXME: Implement.

- return String();

- case MenuListPopupRole:

- // FIXME: Implement.

- return String();

+ return queryString(WebLocalizedString::AXPopUpButtonActionVerb);

default:

- return emptyString();

+ return queryString(WebLocalizedString::AXDefaultActionVerb);

}