third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js - Issue 1809533003: DevTools: remove illusionary caching from String.prototype.lineEndings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

Issue 1809533003: DevTools: remove illusionary caching from String.prototype.lineEndings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: String.prototype.lineEndings -> String.prototype.computeLineEndings Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatter.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

index a7873ee21d1913aa96da90efa52719df94c7d47e..c4049b877141f673fad2d9ca040254698fcd4e85 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

@@ -89,9 +89,9 @@ WebInspector.JavaScriptBreakpointsSidebarPane.prototype = {

{

var lineNumber = uiLocation.lineNumber

var columnNumber = uiLocation.columnNumber;

- var contentString = new String(content);

- if (lineNumber < contentString.lineCount()) {

- var lineText = contentString.lineAt(lineNumber);

+ var text = new WebInspector.Text(content || "");

+ if (lineNumber < text.lineCount()) {

+ var lineText = text.lineAt(lineNumber);

var maxSnippetLength = 200;

var snippetStartIndex = columnNumber > 100 ? columnNumber : 0;

snippetElement.textContent = lineText.substr(snippetStartIndex).trimEnd(maxSnippetLength);