third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js - Issue 1809533003: DevTools: remove illusionary caching from String.prototype.lineEndings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

Issue 1809533003: DevTools: remove illusionary caching from String.prototype.lineEndings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: String.prototype.lineEndings -> String.prototype.computeLineEndings Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/CSSProperty.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

diff --git a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js b/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

index 2b0f05d4deec4125d5b2e2233417b379b0580295..876a93a98d7f24ef82d27fefea7ea285684808bf 100644

--- a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

+++ b/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

@@ -486,7 +486,7 @@ WebInspector.SourceFrame.prototype = {

var currentRangeIndex = insertionIndexForObjectInListSortedByFunction(this._textEditor.selection(), ranges, WebInspector.TextRange.comparator);

var lastRangeIndex = mod(currentRangeIndex - 1, ranges.length);

var lastRange = ranges[lastRangeIndex];

- var replacementLineEndings = replacement.lineEndings();

+ var replacementLineEndings = replacement.computeLineEndings();

var replacementLineCount = replacementLineEndings.length;

var lastLineNumber = lastRange.startLine + replacementLineEndings.length - 1;

var lastColumnNumber = lastRange.startColumn;