DevTools: remove illusionary caching from String.prototype.lineEndings

DevTools: remove illusionary caching from String.prototype.lineEndings

The String.prototype.lineEndings pretended to cache the lineEndings value
on the instance of String object. However, it turned out to be working
only for string objects, and not for the string primitives.

For example, consider the following code snippet:

    var a = "foo";
    a.lineEndings(); // caching failed

    var b = new String(a);
    b.lineEndings(); // caching successful

    var c = b.substring(0);
    c.lineEndings(); // caching failed

The patch removes the caching from String.prototype.lineEndings(). Instead, it introduces
WI.Text object, which wraps String, caches lineEndings
properly, and provides some other handy methods.

BUG=none
R=dgozman, pfeldman

Committed: https://crrev.com/838e5ce388c673a1ae71ad411e7ea88be740619c
Cr-Commit-Position: refs/heads/master@{#381620}

[lushnikov, 2016-03-15 23:29:25]

ptal

[lushnikov, 2016-03-15 23:29:32]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-15 23:29:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809533003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809533003/1

[commit-bot: I haz the power, 2016-03-16 01:30:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 01:30:55]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)

[lushnikov, 2016-03-16 08:05:16]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 08:05:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809533003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809533003/60001

[lushnikov, 2016-03-16 08:05:58]

Description was changed from

==========
DevTools: remove illusionary caching from String.prototype.lineEndings

The String.prototype.lineEndings pretended to cache the lineEndings value
on the instance of String object. However, it turned out to be working
only for string objects, and not for the string primitives.

For example, consider the following code snippet:

    var a = "foo";
    a.lineEndings(); // caching failed

    var b = new String(a);
    b.lineEndings(); // caching successful

    var c = b.substring(0);
    c.lineEndings(); // caching failed

The patch removes the caching from String.prototype.lineEndings().

BUG=none
R=dgozman, pfeldman
==========

to

==========
DevTools: remove illusionary caching from String.prototype.lineEndings

The String.prototype.lineEndings pretended to cache the lineEndings value
on the instance of String object. However, it turned out to be working
only for string objects, and not for the string primitives.

For example, consider the following code snippet:

    var a = "foo";
    a.lineEndings(); // caching failed

    var b = new String(a);
    b.lineEndings(); // caching successful

    var c = b.substring(0);
    c.lineEndings(); // caching failed

The patch removes the caching from String.prototype.lineEndings(). Instead, it
introduces
WI.Text object, which wraps String, caches lineEndings
properly, and provides some other handy methods.

BUG=none
R=dgozman, pfeldman
==========

[commit-bot: I haz the power, 2016-03-16 09:20:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 09:20:39]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-03-16 20:19:08]

Please, take another look.

[dgozman, 2016-03-16 20:36:48]

Much better, but I think we should go even further!

https://codereview.chromium.org/1809533003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/common/TextRange.js (right):

https://codereview.chromium.org/1809533003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/TextRange.js:361:
applyToText: function(text)
Is this one used?

https://codereview.chromium.org/1809533003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/platform/utilities.js (right):

https://codereview.chromium.org/1809533003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/platform/utilities.js:115:
String.prototype.lineEndings = function()
Why don't we remove this method?

https://codereview.chromium.org/1809533003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSProperty.js (right):

https://codereview.chromium.org/1809533003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSProperty.js:119: var
newStyleText = text.replaceRange(range , String.sprintf(";%s;", propertyText));
style: extra space before comma

[lushnikov, 2016-03-16 21:04:02]

https://codereview.chromium.org/1809533003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/common/TextRange.js (right):

https://codereview.chromium.org/1809533003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/TextRange.js:361:
applyToText: function(text)
On 2016/03/16 20:36:48, dgozman wrote:
> Is this one used?

There was a single client; i inlined it and removed the method.

https://codereview.chromium.org/1809533003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/platform/utilities.js (right):

https://codereview.chromium.org/1809533003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/platform/utilities.js:115:
String.prototype.lineEndings = function()
On 2016/03/16 20:36:48, dgozman wrote:
> Why don't we remove this method?

It still comes handy in formatter worker.

https://codereview.chromium.org/1809533003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSProperty.js (right):

https://codereview.chromium.org/1809533003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/CSSProperty.js:119: var
newStyleText = text.replaceRange(range , String.sprintf(";%s;", propertyText));
On 2016/03/16 20:36:48, dgozman wrote:
> style: extra space before comma

Done.

[dgozman, 2016-03-16 21:11:18]

lgtm

https://codereview.chromium.org/1809533003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/platform/utilities.js (right):

https://codereview.chromium.org/1809533003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/platform/utilities.js:115:
String.prototype.lineEndings = function()
As agreed, rename to computeLineEndings.

[lushnikov, 2016-03-17 00:00:27]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-03-17 00:00:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1809533003/#ps120001
(title: "String.prototype.lineEndings -> String.prototype.computeLineEndings")

[lushnikov, 2016-03-17 00:00:39]

https://codereview.chromium.org/1809533003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/platform/utilities.js (right):

https://codereview.chromium.org/1809533003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/platform/utilities.js:115:
String.prototype.lineEndings = function()
On 2016/03/16 21:11:18, dgozman wrote:
> As agreed, rename to computeLineEndings.

Done.

[commit-bot: I haz the power, 2016-03-17 00:01:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809533003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809533003/120001

[commit-bot: I haz the power, 2016-03-17 01:09:52]

Description was changed from

==========
DevTools: remove illusionary caching from String.prototype.lineEndings

The String.prototype.lineEndings pretended to cache the lineEndings value
on the instance of String object. However, it turned out to be working
only for string objects, and not for the string primitives.

For example, consider the following code snippet:

    var a = "foo";
    a.lineEndings(); // caching failed

    var b = new String(a);
    b.lineEndings(); // caching successful

    var c = b.substring(0);
    c.lineEndings(); // caching failed

The patch removes the caching from String.prototype.lineEndings(). Instead, it
introduces
WI.Text object, which wraps String, caches lineEndings
properly, and provides some other handy methods.

BUG=none
R=dgozman, pfeldman
==========

to

==========
DevTools: remove illusionary caching from String.prototype.lineEndings

The String.prototype.lineEndings pretended to cache the lineEndings value
on the instance of String object. However, it turned out to be working
only for string objects, and not for the string primitives.

For example, consider the following code snippet:

    var a = "foo";
    a.lineEndings(); // caching failed

    var b = new String(a);
    b.lineEndings(); // caching successful

    var c = b.substring(0);
    c.lineEndings(); // caching failed

The patch removes the caching from String.prototype.lineEndings(). Instead, it
introduces
WI.Text object, which wraps String, caches lineEndings
properly, and provides some other handy methods.

BUG=none
R=dgozman, pfeldman
==========

[commit-bot: I haz the power, 2016-03-17 01:09:54]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-17 01:12:17]

Description was changed from

==========
DevTools: remove illusionary caching from String.prototype.lineEndings

The String.prototype.lineEndings pretended to cache the lineEndings value
on the instance of String object. However, it turned out to be working
only for string objects, and not for the string primitives.

For example, consider the following code snippet:

    var a = "foo";
    a.lineEndings(); // caching failed

    var b = new String(a);
    b.lineEndings(); // caching successful

    var c = b.substring(0);
    c.lineEndings(); // caching failed

The patch removes the caching from String.prototype.lineEndings(). Instead, it
introduces
WI.Text object, which wraps String, caches lineEndings
properly, and provides some other handy methods.

BUG=none
R=dgozman, pfeldman
==========

to

==========
DevTools: remove illusionary caching from String.prototype.lineEndings

The String.prototype.lineEndings pretended to cache the lineEndings value
on the instance of String object. However, it turned out to be working
only for string objects, and not for the string primitives.

For example, consider the following code snippet:

    var a = "foo";
    a.lineEndings(); // caching failed

    var b = new String(a);
    b.lineEndings(); // caching successful

    var c = b.substring(0);
    c.lineEndings(); // caching failed

The patch removes the caching from String.prototype.lineEndings(). Instead, it
introduces
WI.Text object, which wraps String, caches lineEndings
properly, and provides some other handy methods.

BUG=none
R=dgozman, pfeldman

Committed: https://crrev.com/838e5ce388c673a1ae71ad411e7ea88be740619c
Cr-Commit-Position: refs/heads/master@{#381620}
==========

[commit-bot: I haz the power, 2016-03-17 01:12:18]

Patchset 7 (id:??) landed as
https://crrev.com/838e5ce388c673a1ae71ad411e7ea88be740619c
Cr-Commit-Position: refs/heads/master@{#381620}