Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: trunk/Source/core/rendering/compositing/RenderLayerCompositor.cpp

Issue 180953009: Revert 168554 "Reduce compositing update in Silk's toggle_drawer..." (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/Source/core/rendering/compositing/RenderLayerCompositor.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/core/rendering/compositing/RenderLayerCompositor.cpp
===================================================================
--- trunk/Source/core/rendering/compositing/RenderLayerCompositor.cpp (revision 168555)
+++ trunk/Source/core/rendering/compositing/RenderLayerCompositor.cpp (working copy)
@@ -204,7 +204,6 @@
, m_showRepaintCounter(false)
, m_needsToRecomputeCompositingRequirements(false)
, m_needsToUpdateLayerTreeGeometry(false)
- , m_pendingUpdateType(GraphicsLayerUpdater::DoNotForceUpdate)
, m_compositing(false)
, m_compositingLayersNeedRebuild(false)
, m_forceCompositingMode(false)
@@ -363,23 +362,15 @@
switch (updateType) {
case CompositingUpdateAfterStyleChange:
- m_needsToRecomputeCompositingRequirements = true;
- break;
case CompositingUpdateAfterLayout:
m_needsToRecomputeCompositingRequirements = true;
- // FIXME: Ideally we'd be smarter about tracking dirtiness and wouldn't need a ForceUpdate here.
- m_pendingUpdateType = GraphicsLayerUpdater::ForceUpdate;
break;
case CompositingUpdateOnScroll:
m_needsToRecomputeCompositingRequirements = true; // Overlap can change with scrolling, so need to check for hierarchy updates.
m_needsToUpdateLayerTreeGeometry = true;
- // FIXME: Ideally we'd be smarter about tracking dirtiness and wouldn't need a ForceUpdate here.
- m_pendingUpdateType = GraphicsLayerUpdater::ForceUpdate;
break;
case CompositingUpdateOnCompositedScroll:
m_needsToUpdateLayerTreeGeometry = true;
- // FIXME: Ideally we'd be smarter about tracking dirtiness and wouldn't need a ForceUpdate here.
- m_pendingUpdateType = GraphicsLayerUpdater::ForceUpdate;
break;
}
@@ -428,14 +419,10 @@
if (!needCompositingRequirementsUpdate && !needHierarchyAndGeometryUpdate && !needGeometryUpdate && !needsToUpdateScrollingCoordinator)
return;
- GraphicsLayerUpdater::UpdateType updateType = m_pendingUpdateType;
-
// Only clear the flags if we're updating the entire hierarchy.
m_compositingLayersNeedRebuild = false;
m_needsToUpdateLayerTreeGeometry = false;
m_needsToRecomputeCompositingRequirements = false;
- m_pendingUpdateType = GraphicsLayerUpdater::DoNotForceUpdate;
-
RenderLayer* updateRoot = rootRenderLayer();
if (needCompositingRequirementsUpdate) {
@@ -484,7 +471,7 @@
Vector<GraphicsLayer*> childList;
{
TRACE_EVENT0("blink_rendering", "GraphicsLayerUpdater::rebuildTree");
- GraphicsLayerUpdater(*m_renderView).rebuildTree(*updateRoot, updateType, childList, 0);
+ GraphicsLayerUpdater(*m_renderView).rebuildTree(*updateRoot, childList, 0);
}
// Host the document layer in the RenderView's root layer.
@@ -504,7 +491,7 @@
// We just need to do a geometry update. This is only used for position:fixed scrolling;
// most of the time, geometry is updated via RenderLayer::styleChanged().
TRACE_EVENT0("blink_rendering", "GraphicsLayerUpdater::updateRecursive");
- GraphicsLayerUpdater(*m_renderView).updateRecursive(*updateRoot, updateType);
+ GraphicsLayerUpdater(*m_renderView).updateRecursive(*updateRoot);
}
ASSERT(updateRoot || !m_compositingLayersNeedRebuild);
@@ -1415,7 +1402,7 @@
reflectionLayer->compositedLayerMapping()->updateCompositedBounds();
}
- compositedLayerMapping->updateGraphicsLayerGeometry(GraphicsLayerUpdater::ForceUpdate);
+ compositedLayerMapping->updateGraphicsLayerGeometry();
if (compositedChildrenOnly)
return;
}
« no previous file with comments | « trunk/Source/core/rendering/compositing/RenderLayerCompositor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698