Remove default values for custom CDM component manifest properties.

Remove default values for custom CDM component manifest properties.

Versions that manifests without these values are no longer supported.

BUG=314162
TEST=Manually verified that the CDM still works using a manifest from M33.
R=sorin@chromium.org, xhwang@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255426

[ddorwin, 2014-03-05 22:44:03]

https://codereview.chromium.org/180953006/diff/1/chrome/browser/component_upd...
File chrome/browser/component_updater/widevine_cdm_component_installer.cc
(right):

https://codereview.chromium.org/180953006/diff/1/chrome/browser/component_upd...
chrome/browser/component_updater/widevine_cdm_component_installer.cc:152: return
false;
Note: A missing string is a failure, but an empty string (154) moves on to
comparison. Maybe we should fail there too?

[xhwang, 2014-03-06 01:28:41]

lgtm w/ reply

https://codereview.chromium.org/180953006/diff/1/chrome/browser/component_upd...
File chrome/browser/component_updater/widevine_cdm_component_installer.cc
(right):

https://codereview.chromium.org/180953006/diff/1/chrome/browser/component_upd...
chrome/browser/component_updater/widevine_cdm_component_installer.cc:152: return
false;
On 2014/03/05 22:44:03, ddorwin wrote:
> Note: A missing string is a failure, but an empty string (154) moves on to
> comparison. Maybe we should fail there too?

If the string is empty, it should return false at l.171, right?

[ddorwin, 2014-03-06 02:03:53]

sorin, please OWNERS review this small code removal.

https://codereview.chromium.org/180953006/diff/1/chrome/browser/component_upd...
File chrome/browser/component_updater/widevine_cdm_component_installer.cc
(right):

https://codereview.chromium.org/180953006/diff/1/chrome/browser/component_upd...
chrome/browser/component_updater/widevine_cdm_component_installer.cc:152: return
false;
On 2014/03/06 01:28:42, xhwang wrote:
> On 2014/03/05 22:44:03, ddorwin wrote:
> > Note: A missing string is a failure, but an empty string (154) moves on to
> > comparison. Maybe we should fail there too?
> 
> If the string is empty, it should return false at l.171, right?

Yes.

[Sorin Jianu, 2014-03-06 02:41:22]

lgtm

Thank you!

[ddorwin, 2014-03-06 21:07:29]

Committed patchset #1 manually as r255426 (presubmit successful).