Remove default values for custom CDM component manifest properties.

chrome/browser/component_updater/widevine_cdm_component_installer.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/component_updater/widevine_cdm_component_installer.h"
 
 #include <string.h>
 
 #include <vector>
 
@@ skipping 130 matching lines @@
   return true;
 }
 
 typedef bool (*VersionCheckFunc)(int version);
 
 bool CheckForCompatibleVersion(const base::DictionaryValue& manifest,
                                const std::string version_name,
                                VersionCheckFunc version_check_func) {
   std::string versions_string;
   if (!manifest.GetString(version_name, &versions_string)) {
-    DLOG(WARNING)
-        << "Widevine CDM component manifest is missing " << version_name;
-    // TODO(ddorwin): Remove this once all users have been updated.
-    // The original manifests did not include this string, so add its version.
-    if (version_name == kCdmModuleVersionsName)
-      versions_string = "4";
-    else if (version_name == kCdmInterfaceVersionsName)
-      versions_string = "1";
-    else if (version_name == kCdmHostVersionsName)
-      versions_string = "1";
+    DLOG(WARNING) << "Widevine CDM component manifest missing " << version_name;
+    return false;

[ddorwin, 2014/03/05 22:44:03]

Note: A missing string is a failure, but an empty string (154) moves on to
comparison. Maybe we should fail there too?

[xhwang, 2014/03/06 01:28:42]

If the string is empty, it should return false at l.171, right?

[ddorwin, 2014/03/06 02:03:53]

Yes.

   }
   DLOG_IF(WARNING, versions_string.empty())
       << "Widevine CDM component manifest has empty " << version_name;
 
   std::vector<std::string> versions;
   base::SplitString(versions_string,
                     kCdmValueDelimiter,
                     &versions);
 
   for (size_t i = 0; i < versions.size(); ++i) {
@@ skipping 210 matching lines @@
   DefaultComponentInstaller* installer
       = new DefaultComponentInstaller(traits.Pass());
   installer->Register(cus);
 #else
   return;
 #endif  // defined(WIDEVINE_CDM_AVAILABLE) && defined(WIDEVINE_CDM_IS_COMPONENT)
 }
 
 }  // namespace component_updater