Issue 1809473003: Decrease mismatches in feature extraction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1809473003: Decrease mismatches in feature extraction (Closed)

Created:
4 years, 9 months ago by wychen

Modified:
4 years, 4 months ago

Reviewers:
mdjones

Base URL:
git@github.com:chromium/dom-distiller.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Decrease mismatches in feature extraction Fix isVisible() to match the behavior of native implementation in Chrome https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp&l=58&rcl=1457954878 BUG=595120 R=mdjones@chromium.org Committed: 8a12e18c8c74a9c537cd994405405a9e6e98cd99

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	heuristics/distillable/extract_features.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Dependent Patchsets:

Total messages: 5 (2 generated)

wychen

4 years, 4 months ago (2016-08-10 01:36:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8a12e18c8c74a9c537cd994405405a9e6e98cd99 (presubmit successful).