heuristics/distillable/extract_features.js - Issue 1809473003: Decrease mismatches in feature extraction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: heuristics/distillable/extract_features.js

Issue 1809473003: Decrease mismatches in feature extraction (Closed) Base URL: git@github.com:chromium/dom-distiller.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: heuristics/distillable/extract_features.js

diff --git a/heuristics/distillable/extract_features.js b/heuristics/distillable/extract_features.js

index 5392aa052fa65ee65d337f5d3cfe8af03c343183..068c71e1bb61e921cd0c98861c48442936401398 100644

--- a/heuristics/distillable/extract_features.js

+++ b/heuristics/distillable/extract_features.js

@@ -14,7 +14,7 @@ return (function() {

var bounds = e.getBoundingClientRect()

var style = window.getComputedStyle(e);

return !(

- bounds.height == 0 || bounds.width == 0 ||

+ (bounds.height == 0 && bounds.width == 0) ||

style.display == "none" ||

style.visibility == "hidden" ||

style.opacity == 0

« no previous file with comments | « no previous file | no next file » | no next file with comments »