Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Issue 1809473002: Remove -Wno-inconsistent-missing-override for clang-cl builds. (Closed)

Created:
4 years, 9 months ago by Oliver Chang
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove -Wno-inconsistent-missing-override for clang-cl builds. Fix warnings in win32_int.h R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/2b2cbebe77bc927febdf527c9e7857067873133e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -66 lines) Patch
M build/standalone.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M core/fxge/win32/win32_int.h View 3 chunks +63 lines, -63 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Oliver Chang
4 years, 9 months ago (2016-03-15 21:50:52 UTC) #1
Oliver Chang
Tom, ptal.
4 years, 9 months ago (2016-03-15 21:51:06 UTC) #4
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-15 21:59:10 UTC) #5
Oliver Chang
4 years, 9 months ago (2016-03-15 22:03:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b2cbebe77bc927febdf527c9e7857067873133e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698