Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/standalone.gypi

Issue 1809473002: Remove -Wno-inconsistent-missing-override for clang-cl builds. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | core/fxge/win32/win32_int.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index 6d1d3cb5c5a977a3cee076310971ea18ad23ec43..fe4995beb0ba35f86148113e9ca9c566a8921dee 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -336,9 +336,6 @@
'-Wno-microsoft-enum-value', # http://crbug.com/505296
'-Wno-unknown-pragmas', # http://crbug.com/505314
'-Wno-microsoft-cast', # http://crbug.com/550065
-
- # TODO(ochang): Fix these properly eventually.
- '-Wno-inconsistent-missing-override',
],
}],
['OS=="win" and clang==1 and MSVS_VERSION == "2013"', {
« no previous file with comments | « no previous file | core/fxge/win32/win32_int.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698