build/toolchain/gcc_toolchain.gni - Issue 1809273002: Enable whole-program virtual function optimization in LTO mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/gcc_toolchain.gni

Issue 1809273002: Enable whole-program virtual function optimization in LTO mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/gcc_toolchain.gni

diff --git a/build/toolchain/gcc_toolchain.gni b/build/toolchain/gcc_toolchain.gni

index 90f77793f397c6d2680b969e2a0435970dfcbb27..e2b98e06939138f45a7f34a65990a4efdcc7630a 100644

--- a/build/toolchain/gcc_toolchain.gni

+++ b/build/toolchain/gcc_toolchain.gni

@@ -9,7 +9,7 @@ import("//build/toolchain/goma.gni")

import("//build/toolchain/toolchain.gni")

# This value will be inherited in the toolchain below.

-if (is_lto) {

+if (allow_posix_link_time_opt || is_cfi) {

concurrent_links =

exec_script("get_concurrent_links.py", [ "--lto" ], "value")

} else {

@@ -217,7 +217,8 @@ template("gcc_toolchain") {

tool("alink") {

rspfile = "{{output}}.rsp"

arflags = ""

- if (is_lto && invoker.toolchain_os != "nacl") {

+ if ((allow_posix_link_time_opt || is_cfi) &&

+ invoker.toolchain_os != "nacl") {

gold_plugin_path = rebase_path(

"//third_party/llvm-build/Release+Asserts/lib/LLVMgold.so",

root_build_dir)

« no previous file with comments | « build/config/sanitizers/sanitizers.gni ('k') | build/toolchain/toolchain.gni » ('j') | no next file with comments »