Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: build/config/sanitizers/sanitizers.gni

Issue 1809273002: Enable whole-program virtual function optimization in LTO mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/sanitizers/BUILD.gn ('k') | build/toolchain/gcc_toolchain.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sanitizers/sanitizers.gni
diff --git a/build/config/sanitizers/sanitizers.gni b/build/config/sanitizers/sanitizers.gni
index fd0989faca6adb7b3d63ce91d998e575826302c4..f407498ef53f01e1afdc8e30d17331fc2a73ebda 100644
--- a/build/config/sanitizers/sanitizers.gni
+++ b/build/config/sanitizers/sanitizers.gni
@@ -39,6 +39,8 @@ declare_args() {
# Compile with Control Flow Integrity to protect virtual calls and casts.
# See http://clang.llvm.org/docs/ControlFlowIntegrity.html
+ #
+ # TODO(pcc): Remove this flag if/when CFI is enabled in official builds.
is_cfi = false
# By default, Control Flow Integrity will crash the program if it detects a
@@ -72,10 +74,6 @@ declare_args() {
use_custom_libcxx = (is_asan && is_linux) || is_tsan || is_msan || is_ubsan ||
is_ubsan_security || use_libfuzzer
- # Enable Link Time Optimization (output programs runs faster,
- # but linking is up to 5-20x slower.
- is_lto = is_cfi
-
use_sanitizer_coverage = use_libfuzzer
}
« no previous file with comments | « build/config/sanitizers/BUILD.gn ('k') | build/toolchain/gcc_toolchain.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698