Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1809203005: [NTP Offline Pages] Use the "offline bolt" icon, delete the old one (Closed)

Created:
4 years, 9 months ago by Marc Treib
Modified:
4 years, 9 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, fgorski
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Offline Pages] Use the "offline bolt" icon, delete the old one BUG=595270 Committed: https://crrev.com/70588c566c9586dc1fc3ad7e280d1b3ddf202dcc Cr-Commit-Position: refs/heads/master@{#382320}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Messages

Total messages: 10 (3 generated)
Marc Treib
4 years, 9 months ago (2016-03-18 15:12:18 UTC) #2
newt (away)
https://codereview.chromium.org/1809203005/diff/1/chrome/android/java/res/layout/most_visited_item.xml File chrome/android/java/res/layout/most_visited_item.xml (right): https://codereview.chromium.org/1809203005/diff/1/chrome/android/java/res/layout/most_visited_item.xml#newcode31 chrome/android/java/res/layout/most_visited_item.xml:31: android:tint="#4285f4" android:tint won't have any effect on pre-L devices. ...
4 years, 9 months ago (2016-03-18 18:06:36 UTC) #3
Marc Treib
https://codereview.chromium.org/1809203005/diff/1/chrome/android/java/res/layout/most_visited_item.xml File chrome/android/java/res/layout/most_visited_item.xml (right): https://codereview.chromium.org/1809203005/diff/1/chrome/android/java/res/layout/most_visited_item.xml#newcode31 chrome/android/java/res/layout/most_visited_item.xml:31: android:tint="#4285f4" On 2016/03/18 18:06:36, newt wrote: > android:tint won't ...
4 years, 9 months ago (2016-03-21 09:30:14 UTC) #4
newt (away)
lgtm :)
4 years, 9 months ago (2016-03-21 16:37:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809203005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809203005/20001
4 years, 9 months ago (2016-03-21 17:02:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 17:44:08 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 17:46:34 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70588c566c9586dc1fc3ad7e280d1b3ddf202dcc
Cr-Commit-Position: refs/heads/master@{#382320}

Powered by Google App Engine
This is Rietveld 408576698