Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 | 5 |
| 6 <!-- A most visited item, for display on the new tab page. --> | 6 <!-- A most visited item, for display on the new tab page. --> |
| 7 <org.chromium.chrome.browser.ntp.MostVisitedItemView | 7 <org.chromium.chrome.browser.ntp.MostVisitedItemView |
| 8 xmlns:android="http://schemas.android.com/apk/res/android" | 8 xmlns:android="http://schemas.android.com/apk/res/android" |
| 9 android:layout_width="@dimen/most_visited_tile_width" | 9 android:layout_width="@dimen/most_visited_tile_width" |
| 10 android:layout_height="wrap_content" | 10 android:layout_height="wrap_content" |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 21 android:contentDescription="@null" /> | 21 android:contentDescription="@null" /> |
| 22 | 22 |
| 23 <ImageView | 23 <ImageView |
| 24 android:id="@+id/offline_badge" | 24 android:id="@+id/offline_badge" |
| 25 android:layout_width="@dimen/most_visited_offline_badge_size" | 25 android:layout_width="@dimen/most_visited_offline_badge_size" |
| 26 android:layout_height="@dimen/most_visited_offline_badge_size" | 26 android:layout_height="@dimen/most_visited_offline_badge_size" |
| 27 android:layout_marginStart="48dp" | 27 android:layout_marginStart="48dp" |
| 28 android:visibility="gone" | 28 android:visibility="gone" |
| 29 android:background="@drawable/offline_badge_background" | 29 android:background="@drawable/offline_badge_background" |
| 30 android:contentDescription="@null" | 30 android:contentDescription="@null" |
| 31 android:src="@drawable/offline_pin" /> | 31 android:tint="#4285f4" |
|
newt (away)
2016/03/18 18:06:36
android:tint won't have any effect on pre-L device
Marc Treib
2016/03/21 09:30:14
Thanks, good catch! Done.
| |
| 32 android:src="@drawable/offline_bolt" /> | |
| 32 | 33 |
| 33 <View | 34 <View |
| 34 android:layout_width="@dimen/most_visited_icon_size" | 35 android:layout_width="@dimen/most_visited_icon_size" |
| 35 android:layout_height="@dimen/most_visited_icon_size" | 36 android:layout_height="@dimen/most_visited_icon_size" |
| 36 android:layout_marginStart="12dp" | 37 android:layout_marginStart="12dp" |
| 37 android:layout_marginEnd="12dp" | 38 android:layout_marginEnd="12dp" |
| 38 android:layout_marginTop="12dp" | 39 android:layout_marginTop="12dp" |
| 39 android:background="@drawable/most_visited_item_highlight" /> | 40 android:background="@drawable/most_visited_item_highlight" /> |
| 40 | 41 |
| 41 <TextView | 42 <TextView |
| 42 android:id="@+id/most_visited_title" | 43 android:id="@+id/most_visited_title" |
| 43 android:layout_width="72dp" | 44 android:layout_width="72dp" |
| 44 android:layout_height="wrap_content" | 45 android:layout_height="wrap_content" |
| 45 android:layout_marginTop="66dp" | 46 android:layout_marginTop="66dp" |
| 46 android:ellipsize="end" | 47 android:ellipsize="end" |
| 47 android:gravity="center_horizontal" | 48 android:gravity="center_horizontal" |
| 48 android:lines="2" | 49 android:lines="2" |
| 49 android:lineSpacingMultiplier="1.17" | 50 android:lineSpacingMultiplier="1.17" |
| 50 android:textColor="#787878" | 51 android:textColor="#787878" |
| 51 android:textSize="12sp" /> | 52 android:textSize="12sp" /> |
| 52 | 53 |
| 53 </org.chromium.chrome.browser.ntp.MostVisitedItemView> | 54 </org.chromium.chrome.browser.ntp.MostVisitedItemView> |
| OLD | NEW |