gpu_messages.h => gpu/ipc/common

gpu_messages.h => gpu/ipc/common

This cl moves gpu_messages.h and associated dependencies
all to gpu/ipc/common.

It turns out that NaCl depends on gpu/ipc/common, and we
cannot link skia into NaCl and so I split up gpu/ipc/common
into two source_sets in GN and two gypis on GYP:
command_buffer_traits and ipc_common_sources (GN) /
gpu_ipc_common (GYP).

The parts that NaCl needs live in command_buffer_traits and
that's what NaCl depends on.

Other dependencies that moved are:

gpu_param_traits.cc
gpu_param_traits.h
gpu_param_traits_macros.h
gpu_stream_constants.h

BUG=595721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad
Cr-Commit-Position: refs/heads/master@{#382514}

[Fady Samuel, 2016-03-17 18:54:36]

Description was changed from

==========
[wip] gpu_stream_constants.h => gpu/ipc/common

BUG=
==========

to

==========
[wip] gpu_stream_constants.h => gpu/ipc/common

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-03-17 18:55:10]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 18:55:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/1

[commit-bot: I haz the power, 2016-03-17 20:38:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 20:38:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-03-18 01:23:12]

Description was changed from

==========
[wip] gpu_stream_constants.h => gpu/ipc/common

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
[wip] gpu_messages.h => gpu/ipc/common

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-03-18 02:05:35]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 02:05:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/60001

[commit-bot: I haz the power, 2016-03-18 02:08:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 02:08:34]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-03-18 02:28:29]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 02:28:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/80001

[commit-bot: I haz the power, 2016-03-18 02:38:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 02:38:06]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-03-18 03:15:49]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 03:16:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/80001

[commit-bot: I haz the power, 2016-03-18 03:25:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 03:25:29]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-03-18 03:52:34]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 03:52:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/100001

[commit-bot: I haz the power, 2016-03-18 03:56:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 03:56:51]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-03-18 04:00:57]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 04:01:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/120001

[commit-bot: I haz the power, 2016-03-18 04:11:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 04:11:06]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-03-18 14:03:28]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 14:03:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/140001

[commit-bot: I haz the power, 2016-03-18 14:13:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 14:13:32]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-03-18 14:31:52]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 14:32:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/160001

[commit-bot: I haz the power, 2016-03-18 14:41:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 14:41:12]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-03-18 14:57:07]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 14:57:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/180001

[commit-bot: I haz the power, 2016-03-18 15:06:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 15:06:27]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-03-18 22:20:41]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 22:21:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/200001

[commit-bot: I haz the power, 2016-03-18 22:26:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 22:26:25]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Fady Samuel, 2016-03-18 22:34:13]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 22:34:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/220001

[commit-bot: I haz the power, 2016-03-18 22:57:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 22:57:42]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-03-18 23:00:48]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 23:01:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/230001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/230001

[Fady Samuel, 2016-03-18 23:04:24]

Description was changed from

==========
[wip] gpu_messages.h => gpu/ipc/common

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
gpu_messages.h => gpu/ipc/common

This cl moves gpu_messages.h and associated dependencies all to gpu/ipc/common.

It turns out that NaCl depends on gpu/ipc/common, and we 
cannot link skia into NaCl and so I split up gpu/ipc/common 
into two source_sets in GN and two gypis on GYP: 
command_buffer_traits and ipc_common_sources (GN) / 
gpu_ipc_common (GYP).

The parts that NaCl needs live in command_buffer_traits and 
that's what NaCl depends on.

Other dependencies that moved are:

gpu_param_traits.cc
gpu_param_traits.h
gpu_param_traits_macros.h
gpu_stream_constants.h

BUG=595721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-03-18 23:04:52]

fsamuel@chromium.org changed reviewers:
+ piman@chromium.org

[Fady Samuel, 2016-03-18 23:14:43]

Description was changed from

==========
gpu_messages.h => gpu/ipc/common

This cl moves gpu_messages.h and associated dependencies all to gpu/ipc/common.

It turns out that NaCl depends on gpu/ipc/common, and we 
cannot link skia into NaCl and so I split up gpu/ipc/common 
into two source_sets in GN and two gypis on GYP: 
command_buffer_traits and ipc_common_sources (GN) / 
gpu_ipc_common (GYP).

The parts that NaCl needs live in command_buffer_traits and 
that's what NaCl depends on.

Other dependencies that moved are:

gpu_param_traits.cc
gpu_param_traits.h
gpu_param_traits_macros.h
gpu_stream_constants.h

BUG=595721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
gpu_messages.h => gpu/ipc/common

This cl moves gpu_messages.h and associated dependencies 
all to gpu/ipc/common.

It turns out that NaCl depends on gpu/ipc/common, and we 
cannot link skia into NaCl and so I split up gpu/ipc/common 
into two source_sets in GN and two gypis on GYP: 
command_buffer_traits and ipc_common_sources (GN) / 
gpu_ipc_common (GYP).

The parts that NaCl needs live in command_buffer_traits and 
that's what NaCl depends on.

Other dependencies that moved are:

gpu_param_traits.cc
gpu_param_traits.h
gpu_param_traits_macros.h
gpu_stream_constants.h

BUG=595721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-18 23:18:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 23:18:05]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-03-18 23:46:29]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 23:47:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/250001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/250001

[piman, 2016-03-18 23:48:06]

Which part needs Skia? I'm hoping to use the client side of  gpu/ipc in ppapi,
which needs to compile in nacl. gpu shouldn't depend on skia (circular
dependencies)

[Fady Samuel, 2016-03-18 23:53:21]

On 2016/03/18 23:48:06, piman wrote:
> Which part needs Skia? I'm hoping to use the client side of  gpu/ipc in ppapi,
> which needs to compile in nacl. gpu shouldn't depend on skia (circular
> dependencies)

I think ui/gfx ends up pulling in skia? gpu/ipc/common/gpu_messages.h depends on
ui/gfx/ipc.

[Fady Samuel, 2016-03-19 00:05:09]

On 2016/03/18 23:53:21, Fady Samuel wrote:
> On 2016/03/18 23:48:06, piman wrote:
> > Which part needs Skia? I'm hoping to use the client side of  gpu/ipc in
ppapi,
> > which needs to compile in nacl. gpu shouldn't depend on skia (circular
> > dependencies)
> 
> I think ui/gfx ends up pulling in skia? gpu/ipc/common/gpu_messages.h depends
on
> ui/gfx/ipc.

Could we introduce a public interface on the client side code that ppapi depends
on that doesn't depend on ui/gfx?

Could we dice ui/gfx into a target that doesn't depend on skia that gpu/ipc can
depend on?

[commit-bot: I haz the power, 2016-03-19 00:08:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 00:08:08]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[danakj, 2016-03-19 00:12:25]

On 2016/03/19 00:05:09, Fady Samuel wrote:
> On 2016/03/18 23:53:21, Fady Samuel wrote:
> > On 2016/03/18 23:48:06, piman wrote:
> > > Which part needs Skia? I'm hoping to use the client side of  gpu/ipc in
> ppapi,
> > > which needs to compile in nacl. gpu shouldn't depend on skia (circular
> > > dependencies)
> > 
> > I think ui/gfx ends up pulling in skia? gpu/ipc/common/gpu_messages.h
depends
> on
> > ui/gfx/ipc.
> 
> Could we introduce a public interface on the client side code that ppapi
depends
> on that doesn't depend on ui/gfx?
> 
> Could we dice ui/gfx into a target that doesn't depend on skia that gpu/ipc
can
> depend on?

ui/gfx/ (excluding some subdirs like geometry..) is basically wrappers around
skia stuff.

[piman, 2016-03-19 00:16:45]

On Fri, Mar 18, 2016 at 5:12 PM, <danakj@chromium.org> wrote:

> On 2016/03/19 00:05:09, Fady Samuel wrote:
> > On 2016/03/18 23:53:21, Fady Samuel wrote:
> > > On 2016/03/18 23:48:06, piman wrote:
> > > > Which part needs Skia? I'm hoping to use the client side of gpu/ipc
> in
> > ppapi,
> > > > which needs to compile in nacl. gpu shouldn't depend on skia
> (circular
> > > > dependencies)
> > >
> > > I think ui/gfx ends up pulling in skia? gpu/ipc/common/gpu_messages.h
> depends
> > on
> > > ui/gfx/ipc.
> >
> > Could we introduce a public interface on the client side code that ppapi
> depends
> > on that doesn't depend on ui/gfx?
> >
> > Could we dice ui/gfx into a target that doesn't depend on skia that
> gpu/ipc
> can
> > depend on?
>
> ui/gfx/ (excluding some subdirs like geometry..) is basically wrappers
> around
> skia stuff.
>

I'm pretty sure the only parts of ui/gfx that we need are the non-skia
parts. geometry (gfx::Size), native handles (will move away from ui/ soon),
GpuMemoryBuffers, SwapResults.
So my preference would be to separate those things out of the other ui/gfx
things that need skia.


>
> https://codereview.chromium.org/1809183002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Fady Samuel, 2016-03-19 00:18:52]

On 2016/03/19 00:16:45, piman wrote:
> On Fri, Mar 18, 2016 at 5:12 PM, <mailto:danakj@chromium.org> wrote:
> 
> > On 2016/03/19 00:05:09, Fady Samuel wrote:
> > > On 2016/03/18 23:53:21, Fady Samuel wrote:
> > > > On 2016/03/18 23:48:06, piman wrote:
> > > > > Which part needs Skia? I'm hoping to use the client side of gpu/ipc
> > in
> > > ppapi,
> > > > > which needs to compile in nacl. gpu shouldn't depend on skia
> > (circular
> > > > > dependencies)
> > > >
> > > > I think ui/gfx ends up pulling in skia? gpu/ipc/common/gpu_messages.h
> > depends
> > > on
> > > > ui/gfx/ipc.
> > >
> > > Could we introduce a public interface on the client side code that ppapi
> > depends
> > > on that doesn't depend on ui/gfx?
> > >
> > > Could we dice ui/gfx into a target that doesn't depend on skia that
> > gpu/ipc
> > can
> > > depend on?
> >
> > ui/gfx/ (excluding some subdirs like geometry..) is basically wrappers
> > around
> > skia stuff.
> >
> 
> I'm pretty sure the only parts of ui/gfx that we need are the non-skia
> parts. geometry (gfx::Size), native handles (will move away from ui/ soon),
> GpuMemoryBuffers, SwapResults.
> So my preference would be to separate those things out of the other ui/gfx
> things that need skia.
> 
> 
> >
> > https://codereview.chromium.org/1809183002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Unrelated oddball dependency: ui/events for LatencyInfo I believe.

[chromium-reviews, 2016-03-19 00:24:45]

On Fri, Mar 18, 2016 at 5:16 PM, Antoine Labour <piman@chromium.org> wrote:

>
>
> On Fri, Mar 18, 2016 at 5:12 PM, <danakj@chromium.org> wrote:
>
>> On 2016/03/19 00:05:09, Fady Samuel wrote:
>> > On 2016/03/18 23:53:21, Fady Samuel wrote:
>> > > On 2016/03/18 23:48:06, piman wrote:
>> > > > Which part needs Skia? I'm hoping to use the client side of gpu/ipc
>> in
>> > ppapi,
>> > > > which needs to compile in nacl. gpu shouldn't depend on skia
>> (circular
>> > > > dependencies)
>> > >
>> > > I think ui/gfx ends up pulling in skia? gpu/ipc/common/gpu_messages.h
>> depends
>> > on
>> > > ui/gfx/ipc.
>> >
>> > Could we introduce a public interface on the client side code that ppapi
>> depends
>> > on that doesn't depend on ui/gfx?
>> >
>> > Could we dice ui/gfx into a target that doesn't depend on skia that
>> gpu/ipc
>> can
>> > depend on?
>>
>> ui/gfx/ (excluding some subdirs like geometry..) is basically wrappers
>> around
>> skia stuff.
>>
>
> I'm pretty sure the only parts of ui/gfx that we need are the non-skia
> parts. geometry (gfx::Size), native handles (will move away from ui/ soon),
> GpuMemoryBuffers, SwapResults.
> So my preference would be to separate those things out of the other ui/gfx
> things that need skia.
>

We could split ipc/ up with ipc/geometry/ to match the rest of gfx. I tihnk
I like that better than ipc/ dirs all over gfx.


>
>
>>
>> https://codereview.chromium.org/1809183002/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Fady Samuel, 2016-03-19 00:40:26]

On 2016/03/19 00:24:45, chromium-reviews wrote:
> On Fri, Mar 18, 2016 at 5:16 PM, Antoine Labour <mailto:piman@chromium.org>
wrote:
> 
> >
> >
> > On Fri, Mar 18, 2016 at 5:12 PM, <mailto:danakj@chromium.org> wrote:
> >
> >> On 2016/03/19 00:05:09, Fady Samuel wrote:
> >> > On 2016/03/18 23:53:21, Fady Samuel wrote:
> >> > > On 2016/03/18 23:48:06, piman wrote:
> >> > > > Which part needs Skia? I'm hoping to use the client side of gpu/ipc
> >> in
> >> > ppapi,
> >> > > > which needs to compile in nacl. gpu shouldn't depend on skia
> >> (circular
> >> > > > dependencies)
> >> > >
> >> > > I think ui/gfx ends up pulling in skia? gpu/ipc/common/gpu_messages.h
> >> depends
> >> > on
> >> > > ui/gfx/ipc.
> >> >
> >> > Could we introduce a public interface on the client side code that ppapi
> >> depends
> >> > on that doesn't depend on ui/gfx?
> >> >
> >> > Could we dice ui/gfx into a target that doesn't depend on skia that
> >> gpu/ipc
> >> can
> >> > depend on?
> >>
> >> ui/gfx/ (excluding some subdirs like geometry..) is basically wrappers
> >> around
> >> skia stuff.
> >>
> >
> > I'm pretty sure the only parts of ui/gfx that we need are the non-skia
> > parts. geometry (gfx::Size), native handles (will move away from ui/ soon),
> > GpuMemoryBuffers, SwapResults.
> > So my preference would be to separate those things out of the other ui/gfx
> > things that need skia.
> >
> 
> We could split ipc/ up with ipc/geometry/ to match the rest of gfx. I tihnk
> I like that better than ipc/ dirs all over gfx.
> 
> 
> >
> >
> >>
> >> https://codereview.chromium.org/1809183002/
> >>
> >
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

I'm happy to do further detangling as need be. :-) Are we blocking this CL on
this work?

[Fady Samuel, 2016-03-19 00:51:16]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-19 00:51:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/270001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/270001

[commit-bot: I haz the power, 2016-03-19 01:05:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 01:05:18]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[piman, 2016-03-19 01:16:24]

LGTM, let's land this, no reason to block further refactors. Could you file a
bug to follow up?

[Fady Samuel, 2016-03-19 01:37:07]

fsamuel@chromium.org changed reviewers:
+ dcheng@chromium.org, sadrul@chromium.org

[Fady Samuel, 2016-03-19 01:37:08]

+dcheng@ for IPC (I don't believe anything has changed, this is just moving IPC
messages around).
+sadrul@ for ui/events dependency (I'm TBR'ing him since he's the only OWNER it
seems and he's on vacation).

[Fady Samuel, 2016-03-19 01:38:04]

Description was changed from

==========
gpu_messages.h => gpu/ipc/common

This cl moves gpu_messages.h and associated dependencies 
all to gpu/ipc/common.

It turns out that NaCl depends on gpu/ipc/common, and we 
cannot link skia into NaCl and so I split up gpu/ipc/common 
into two source_sets in GN and two gypis on GYP: 
command_buffer_traits and ipc_common_sources (GN) / 
gpu_ipc_common (GYP).

The parts that NaCl needs live in command_buffer_traits and 
that's what NaCl depends on.

Other dependencies that moved are:

gpu_param_traits.cc
gpu_param_traits.h
gpu_param_traits_macros.h
gpu_stream_constants.h

BUG=595721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
gpu_messages.h => gpu/ipc/common

This cl moves gpu_messages.h and associated dependencies 
all to gpu/ipc/common.

It turns out that NaCl depends on gpu/ipc/common, and we 
cannot link skia into NaCl and so I split up gpu/ipc/common 
into two source_sets in GN and two gypis on GYP: 
command_buffer_traits and ipc_common_sources (GN) / 
gpu_ipc_common (GYP).

The parts that NaCl needs live in command_buffer_traits and 
that's what NaCl depends on.

Other dependencies that moved are:

gpu_param_traits.cc
gpu_param_traits.h
gpu_param_traits_macros.h
gpu_stream_constants.h

BUG=595721
TBR=sadrul@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[chromium-reviews, 2016-03-19 01:39:01]

On Fri, Mar 18, 2016 at 6:37 PM, <fsamuel@chromium.org> wrote:

> +dcheng@ for IPC (I don't believe anything has changed, this is just
> moving IPC
> messages around).
> +sadrul@ for ui/events dependency (I'm TBR'ing him since he's the only
> OWNER it
> seems and he's on vacation).
>

Use ui/OWNERS then.


>
> https://codereview.chromium.org/1809183002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Fady Samuel, 2016-03-19 01:41:16]

Description was changed from

==========
gpu_messages.h => gpu/ipc/common

This cl moves gpu_messages.h and associated dependencies 
all to gpu/ipc/common.

It turns out that NaCl depends on gpu/ipc/common, and we 
cannot link skia into NaCl and so I split up gpu/ipc/common 
into two source_sets in GN and two gypis on GYP: 
command_buffer_traits and ipc_common_sources (GN) / 
gpu_ipc_common (GYP).

The parts that NaCl needs live in command_buffer_traits and 
that's what NaCl depends on.

Other dependencies that moved are:

gpu_param_traits.cc
gpu_param_traits.h
gpu_param_traits_macros.h
gpu_stream_constants.h

BUG=595721
TBR=sadrul@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
gpu_messages.h => gpu/ipc/common

This cl moves gpu_messages.h and associated dependencies 
all to gpu/ipc/common.

It turns out that NaCl depends on gpu/ipc/common, and we 
cannot link skia into NaCl and so I split up gpu/ipc/common 
into two source_sets in GN and two gypis on GYP: 
command_buffer_traits and ipc_common_sources (GN) / 
gpu_ipc_common (GYP).

The parts that NaCl needs live in command_buffer_traits and 
that's what NaCl depends on.

Other dependencies that moved are:

gpu_param_traits.cc
gpu_param_traits.h
gpu_param_traits_macros.h
gpu_stream_constants.h

BUG=595721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-03-19 01:41:49]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org
- sadrul@chromium.org

[Fady Samuel, 2016-03-19 01:41:50]

+sky@ for ui/events dependency.
-sadrul@

[Fady Samuel, 2016-03-19 03:51:30]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-19 03:51:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/290001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/290001

[Fady Samuel, 2016-03-19 03:51:47]

fsamuel@chromium.org changed reviewers:
+ raymes@chromium.org

[Fady Samuel, 2016-03-19 03:51:48]

+raymes@ for ppapi Thanks

[commit-bot: I haz the power, 2016-03-19 04:01:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 04:01:48]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2016-03-19 04:07:57]

lgtm

[raymes, 2016-03-20 22:13:05]

lgtm

[sky, 2016-03-21 16:25:25]

LGTM

[Fady Samuel, 2016-03-21 16:26:04]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-03-21 16:26:05]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1809183002/#ps290001
(title: "Fixed Android Build")

[commit-bot: I haz the power, 2016-03-21 16:26:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/290001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/290001

[Nico, 2016-03-21 17:12:08]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2016-03-21 17:12:42]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-03-21 17:12:44]

This breaks gn component builds, as shown on this new try bot:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang_x64_db...

FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper
environment.x64 False link.exe /nologo /IMPLIB:./mojo_surfaces_lib.dll.lib /DLL
/OUT:./mojo_surfaces_lib.dll /PDB:./mojo_surfaces_lib.dll.pdb
@./mojo_surfaces_lib.dll.rsp
gpu.dll.lib(gpu.dll) : error LNK2005: "public: __cdecl
gpu::Capabilities::Capabilities(void)" (??0Capabilities@gpu@@QEAA@XZ) already
defined in capabilities.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: static void __cdecl
IPC::ParamTraits<struct gpu::CommandBuffer::State>::GetSize(class
base::PickleSizer *,struct gpu::CommandBuffer::State const &)"
(?GetSize@?$ParamTraits@UState@CommandBuffer@gpu@@@IPC@@SAXPEAVPickleSizer@base@@AEBUState@CommandBuffer@gpu@@@Z)
already defined in gpu_command_buffer_traits.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: static void __cdecl
IPC::ParamTraits<struct gpu::CommandBuffer::State>::Write(class base::Pickle
*,struct gpu::CommandBuffer::State const &)"
(?Write@?$ParamTraits@UState@CommandBuffer@gpu@@@IPC@@SAXPEAVPickle@base@@AEBUState@CommandBuffer@gpu@@@Z)
already defined in gpu_command_buffer_traits.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: static bool __cdecl
IPC::ParamTraits<struct gpu::CommandBuffer::State>::Read(class base::Pickle
const *,class base::PickleIterator *,struct gpu::CommandBuffer::State *)"
(?Read@?$ParamTraits@UState@CommandBuffer@gpu@@@IPC@@SA_NPEBVPickle@base@@PEAVPickleIterator@4@PEAUState@CommandBuffer@gpu@@@Z)
already defined in gpu_command_buffer_traits.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: static void __cdecl
IPC::ParamTraits<struct gpu::Mailbox>::GetSize(class base::PickleSizer *,struct
gpu::Mailbox const &)"
(?GetSize@?$ParamTraits@UMailbox@gpu@@@IPC@@SAXPEAVPickleSizer@base@@AEBUMailbox@gpu@@@Z)
already defined in gpu_command_buffer_traits.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: static void __cdecl
IPC::ParamTraits<struct gpu::Mailbox>::Write(class base::Pickle *,struct
gpu::Mailbox const &)"
(?Write@?$ParamTraits@UMailbox@gpu@@@IPC@@SAXPEAVPickle@base@@AEBUMailbox@gpu@@@Z)
already defined in gpu_command_buffer_traits.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: static void __cdecl
IPC::ParamTraits<struct gpu::SyncToken>::GetSize(class base::PickleSizer
*,struct gpu::SyncToken const &)"
(?GetSize@?$ParamTraits@USyncToken@gpu@@@IPC@@SAXPEAVPickleSizer@base@@AEBUSyncToken@gpu@@@Z)
already defined in gpu_command_buffer_traits.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: static void __cdecl
IPC::ParamTraits<struct gpu::SyncToken>::Write(class base::Pickle *,struct
gpu::SyncToken const &)"
(?Write@?$ParamTraits@USyncToken@gpu@@@IPC@@SAXPEAVPickle@base@@AEBUSyncToken@gpu@@@Z)
already defined in gpu_command_buffer_traits.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: __cdecl
gpu::Mailbox::Mailbox(void)" (??0Mailbox@gpu@@QEAA@XZ) already defined in
mailbox.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: __cdecl
gpu::SyncToken::SyncToken(void)" (??0SyncToken@gpu@@QEAA@XZ) already defined in
sync_token.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: static bool __cdecl
IPC::ParamTraits<struct gpu::Mailbox>::Read(class base::Pickle const *,class
base::PickleIterator *,struct gpu::Mailbox *)"
(?Read@?$ParamTraits@UMailbox@gpu@@@IPC@@SA_NPEBVPickle@base@@PEAVPickleIterator@4@PEAUMailbox@gpu@@@Z)
already defined in gpu_command_buffer_traits.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: static bool __cdecl
IPC::ParamTraits<struct gpu::SyncToken>::Read(class base::Pickle const *,class
base::PickleIterator *,struct gpu::SyncToken *)"
(?Read@?$ParamTraits@USyncToken@gpu@@@IPC@@SA_NPEBVPickle@base@@PEAVPickleIterator@4@PEAUSyncToken@gpu@@@Z)
already defined in gpu_command_buffer_traits.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: static void __cdecl
IPC::ParamTraits<struct gpu::Capabilities>::GetSize(class base::PickleSizer
*,struct gpu::Capabilities const &)"
(?GetSize@?$ParamTraits@UCapabilities@gpu@@@IPC@@SAXPEAVPickleSizer@base@@AEBUCapabilities@gpu@@@Z)
already defined in gpu_command_buffer_traits.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: static void __cdecl
IPC::ParamTraits<struct gpu::Capabilities>::Write(class base::Pickle *,struct
gpu::Capabilities const &)"
(?Write@?$ParamTraits@UCapabilities@gpu@@@IPC@@SAXPEAVPickle@base@@AEBUCapabilities@gpu@@@Z)
already defined in gpu_command_buffer_traits.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: static bool __cdecl
IPC::ParamTraits<struct gpu::Capabilities>::Read(class base::Pickle const
*,class base::PickleIterator *,struct gpu::Capabilities *)"
(?Read@?$ParamTraits@UCapabilities@gpu@@@IPC@@SA_NPEBVPickle@base@@PEAVPickleIterator@4@PEAUCapabilities@gpu@@@Z)
already defined in gpu_command_buffer_traits.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: __cdecl
gpu::MailboxHolder::MailboxHolder(void)" (??0MailboxHolder@gpu@@QEAA@XZ) already
defined in mailbox_holder.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: static void __cdecl
IPC::ParamTraits<struct gpu::MailboxHolder>::GetSize(class base::PickleSizer
*,struct gpu::MailboxHolder const &)"
(?GetSize@?$ParamTraits@UMailboxHolder@gpu@@@IPC@@SAXPEAVPickleSizer@base@@AEBUMailboxHolder@gpu@@@Z)
already defined in gpu_command_buffer_traits.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: static void __cdecl
IPC::ParamTraits<struct gpu::MailboxHolder>::Write(class base::Pickle *,struct
gpu::MailboxHolder const &)"
(?Write@?$ParamTraits@UMailboxHolder@gpu@@@IPC@@SAXPEAVPickle@base@@AEBUMailboxHolder@gpu@@@Z)
already defined in gpu_command_buffer_traits.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: static bool __cdecl
IPC::ParamTraits<struct gpu::MailboxHolder>::Read(class base::Pickle const
*,class base::PickleIterator *,struct gpu::MailboxHolder *)"
(?Read@?$ParamTraits@UMailboxHolder@gpu@@@IPC@@SA_NPEBVPickle@base@@PEAVPickleIterator@4@PEAUMailboxHolder@gpu@@@Z)
already defined in gpu_command_buffer_traits.obj

./mojo_surfaces_lib.dll : fatal error LNK1169: one or more multiply defined
symbols found

[Nico, 2016-03-21 17:13:44]

thakis@chromium.org changed reviewers:
+ markdittmer@chromium.org

[Nico, 2016-03-21 17:13:46]

markdittmer can probably tell you how to make this go :-)

[Fady Samuel, 2016-03-21 20:12:03]

Patchset #17 (id:310001) has been deleted

[Fady Samuel, 2016-03-21 20:14:05]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 20:14:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/330001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/330001

[commit-bot: I haz the power, 2016-03-21 20:17:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 20:17:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-03-21 21:38:07]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 21:38:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/370001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/370001

[commit-bot: I haz the power, 2016-03-21 21:50:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 21:50:29]

Dry run: Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)

[Fady Samuel, 2016-03-21 22:53:00]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 22:53:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/390001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/390001

[Fady Samuel, 2016-03-22 00:00:51]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 00:01:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/410001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/410001

[commit-bot: I haz the power, 2016-03-22 01:25:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 01:25:05]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Fady Samuel, 2016-03-22 04:32:22]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-03-22 04:32:23]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
dcheng@chromium.org, piman@chromium.org, raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/1809183002/#ps430001
(title: "Make win_clang_x64_dbg happy by making command_buffer_traits an alias
to gpu component on compnet b…")

[commit-bot: I haz the power, 2016-03-22 04:32:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/430001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/430001

[commit-bot: I haz the power, 2016-03-22 04:50:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 04:50:09]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Fady Samuel, 2016-03-22 04:54:29]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-03-22 04:54:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809183002/430001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809183002/430001

[commit-bot: I haz the power, 2016-03-22 05:38:36]

Description was changed from

==========
gpu_messages.h => gpu/ipc/common

This cl moves gpu_messages.h and associated dependencies 
all to gpu/ipc/common.

It turns out that NaCl depends on gpu/ipc/common, and we 
cannot link skia into NaCl and so I split up gpu/ipc/common 
into two source_sets in GN and two gypis on GYP: 
command_buffer_traits and ipc_common_sources (GN) / 
gpu_ipc_common (GYP).

The parts that NaCl needs live in command_buffer_traits and 
that's what NaCl depends on.

Other dependencies that moved are:

gpu_param_traits.cc
gpu_param_traits.h
gpu_param_traits_macros.h
gpu_stream_constants.h

BUG=595721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
gpu_messages.h => gpu/ipc/common

This cl moves gpu_messages.h and associated dependencies 
all to gpu/ipc/common.

It turns out that NaCl depends on gpu/ipc/common, and we 
cannot link skia into NaCl and so I split up gpu/ipc/common 
into two source_sets in GN and two gypis on GYP: 
command_buffer_traits and ipc_common_sources (GN) / 
gpu_ipc_common (GYP).

The parts that NaCl needs live in command_buffer_traits and 
that's what NaCl depends on.

Other dependencies that moved are:

gpu_param_traits.cc
gpu_param_traits.h
gpu_param_traits_macros.h
gpu_stream_constants.h

BUG=595721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-22 05:38:38]

Committed patchset #22 (id:430001)

[commit-bot: I haz the power, 2016-03-22 05:39:58]

Description was changed from

==========
gpu_messages.h => gpu/ipc/common

This cl moves gpu_messages.h and associated dependencies 
all to gpu/ipc/common.

It turns out that NaCl depends on gpu/ipc/common, and we 
cannot link skia into NaCl and so I split up gpu/ipc/common 
into two source_sets in GN and two gypis on GYP: 
command_buffer_traits and ipc_common_sources (GN) / 
gpu_ipc_common (GYP).

The parts that NaCl needs live in command_buffer_traits and 
that's what NaCl depends on.

Other dependencies that moved are:

gpu_param_traits.cc
gpu_param_traits.h
gpu_param_traits_macros.h
gpu_stream_constants.h

BUG=595721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
gpu_messages.h => gpu/ipc/common

This cl moves gpu_messages.h and associated dependencies
all to gpu/ipc/common.

It turns out that NaCl depends on gpu/ipc/common, and we
cannot link skia into NaCl and so I split up gpu/ipc/common
into two source_sets in GN and two gypis on GYP:
command_buffer_traits and ipc_common_sources (GN) /
gpu_ipc_common (GYP).

The parts that NaCl needs live in command_buffer_traits and
that's what NaCl depends on.

Other dependencies that moved are:

gpu_param_traits.cc
gpu_param_traits.h
gpu_param_traits_macros.h
gpu_stream_constants.h

BUG=595721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad
Cr-Commit-Position: refs/heads/master@{#382514}
==========

[commit-bot: I haz the power, 2016-03-22 05:40:01]

Patchset 22 (id:??) landed as
https://crrev.com/19acfae06352bab6abff2ff7d13456e02be0b7ad
Cr-Commit-Position: refs/heads/master@{#382514}