Issue 1809123002: Pass QuicTime, QuicTime::Delta, and QuicBandwidth exclusively by value. Not flag protected. No func…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1809123002: Pass QuicTime, QuicTime::Delta, and QuicBandwidth exclusively by value. Not flag protected. No func… (Closed)

Created:
4 years, 9 months ago by fnk

Modified:
4 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@116970314

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Pass QuicTime, QuicTime::Delta, and QuicBandwidth exclusively by value. Not flag protected. No functional change. Merge internal change: 116973081 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -11 lines)			Patch
M	net/quic/congestion_control/general_loss_algorithm.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/congestion_control/general_loss_algorithm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/congestion_control/loss_detection_interface.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_bandwidth.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/quic/quic_bandwidth.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 1808963003 Patch 1

Dependent Patchsets:

Issue 1810073002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages