net/quic/quic_sent_packet_manager.h - Issue 1809123002: Pass QuicTime, QuicTime::Delta, and QuicBandwidth exclusively by value. Not flag protected. No func…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_sent_packet_manager.h

Issue 1809123002: Pass QuicTime, QuicTime::Delta, and QuicBandwidth exclusively by value. Not flag protected. No func… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116970314

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_sent_packet_manager.h

diff --git a/net/quic/quic_sent_packet_manager.h b/net/quic/quic_sent_packet_manager.h

index af3b953971fe631cd80dcbd192c00755a6047ad6..c448470202728e08ca16993b544e78e89edd9498 100644

--- a/net/quic/quic_sent_packet_manager.h

+++ b/net/quic/quic_sent_packet_manager.h

@@ -322,8 +322,7 @@ class NET_EXPORT_PRIVATE QuicSentPacketManager {

// Update the RTT if the ack is for the largest acked packet number.

// Returns true if the rtt was updated.

- bool MaybeUpdateRTT(const QuicAckFrame& ack_frame,

- const QuicTime& ack_receive_time);

+ bool MaybeUpdateRTT(const QuicAckFrame& ack_frame, QuicTime ack_receive_time);

// Invokes the loss detection algorithm and loses and retransmits packets if

// necessary.

« no previous file with comments | « net/quic/quic_bandwidth.cc ('k') | net/quic/quic_sent_packet_manager.cc » ('j') | no next file with comments »