Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: media/base/fake_output_device.h

Issue 1809093003: Moving SwitchOutputDevice out of OutputDevice interface, eliminating OutputDevice (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Replace RestartableAudioRendererSink with SwitchableAudioRendererSink in webmediaplayer_impl unit t… Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/fake_output_device.h
diff --git a/media/base/fake_output_device.h b/media/base/fake_output_device.h
index 45a6abb7cfdfd20adae2dc7a59d99a88d11c8c45..d500a995514e065e96f5f3daa368fbe588ef34ff 100644
--- a/media/base/fake_output_device.h
+++ b/media/base/fake_output_device.h
@@ -15,18 +15,21 @@ namespace media {
class FakeOutputDevice : public OutputDevice {
public:
FakeOutputDevice();
- explicit FakeOutputDevice(OutputDeviceStatus status);
+ explicit FakeOutputDevice(const std::string& device_id,
+ OutputDeviceStatus status);
+ FakeOutputDevice(const std::string& device_id,
+ OutputDeviceStatus status,
+ const AudioParameters& params);
~FakeOutputDevice() override;
- // OutputDevice implementation.
Guido Urdaneta 2016/03/17 17:38:24 I think you should keep the comment.
- void SwitchOutputDevice(const std::string& device_id,
- const url::Origin& security_origin,
- const SwitchOutputDeviceCB& callback) override;
AudioParameters GetOutputParameters() override;
OutputDeviceStatus GetDeviceStatus() override;
+ std::string GetDeviceId() override;
private:
- OutputDeviceStatus device_status_;
+ const std::string device_id_;
+ const OutputDeviceStatus status_;
+ const AudioParameters params_;
DISALLOW_COPY_AND_ASSIGN(FakeOutputDevice);
};

Powered by Google App Engine
This is Rietveld 408576698