media/base/audio_renderer_mixer_input_unittest.cc - Issue 1809093003: Moving SwitchOutputDevice out of OutputDevice interface, eliminating OutputDevice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/audio_renderer_mixer_input_unittest.cc

Issue 1809093003: Moving SwitchOutputDevice out of OutputDevice interface, eliminating OutputDevice (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace RestartableAudioRendererSink with SwitchableAudioRendererSink in webmediaplayer_impl unit t… Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/base/audio_renderer_mixer_input.cc ('K') | « media/base/audio_renderer_mixer_input.cc ('k') | media/base/audio_renderer_mixer_unittest.cc » ('j') | media/base/audio_renderer_sink.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/audio_renderer_mixer_input_unittest.cc

diff --git a/media/base/audio_renderer_mixer_input_unittest.cc b/media/base/audio_renderer_mixer_input_unittest.cc

index 42c5179a9a771433abaef58c74387cc3576ccdbe..522b3f92602947c93912e744dd363161fc177b13 100644

--- a/media/base/audio_renderer_mixer_input_unittest.cc

+++ b/media/base/audio_renderer_mixer_input_unittest.cc

@@ -44,7 +44,7 @@ class AudioRendererMixerInputTest : public testing::Test {

base::Unretained(this)),

base::Bind(&AudioRendererMixerInputTest::RemoveMixer,

base::Unretained(this)),

- base::Bind(&AudioRendererMixerInputTest::GetOutputHWParams,

+ base::Bind(&AudioRendererMixerInputTest::GetOutputDevice,

base::Unretained(this)),

device_id, url::Origin());

}

@@ -89,8 +89,8 @@ class AudioRendererMixerInputTest : public testing::Test {

const std::string&,

const url::Origin&));

- MOCK_METHOD2(GetOutputHWParams,

- AudioParameters(const std::string&, const url::Origin&));

+ MOCK_METHOD2(GetOutputDevice,

+ OutputDevice*(const std::string&, const url::Origin&));

MOCK_METHOD1(SwitchCallbackCalled, void(OutputDeviceStatus));

void SwitchCallback(base::RunLoop* loop, OutputDeviceStatus result) {