Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Unified Diff: media/base/audio_renderer_mixer.h

Issue 1809093003: Moving SwitchOutputDevice out of OutputDevice interface, eliminating OutputDevice (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing guidou's comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/audio_renderer_mixer.h
diff --git a/media/base/audio_renderer_mixer.h b/media/base/audio_renderer_mixer.h
index 042c4bebf2b031c4b6bc13a44816c33dc5c996c4..9c712105d98a9eef490f3e650a83643e77942802 100644
--- a/media/base/audio_renderer_mixer.h
+++ b/media/base/audio_renderer_mixer.h
@@ -46,11 +46,7 @@ class MEDIA_EXPORT AudioRendererMixer
pause_delay_ = delay;
}
- // TODO(guidou): remove this method. The output device of a mixer should
- // never be switched, as it may result in a discrepancy between the output
- // parameters of the new device and the output parameters with which the
- // mixer was initialized. See crbug.com/506507
- OutputDevice* GetOutputDevice();
+ OutputDeviceInfo GetOutputDeviceInfo();
miu 2016/03/24 21:32:02 Consider adding bug 506507 to the BUG= line in the
o1ka 2016/03/29 13:39:54 Done.
private:
// Maps input sample rate to the dedicated converter.

Powered by Google App Engine
This is Rietveld 408576698