media/base/BUILD.gn - Issue 1809093003: Moving SwitchOutputDevice out of OutputDevice interface, eliminating OutputDevice

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/BUILD.gn

Issue 1809093003: Moving SwitchOutputDevice out of OutputDevice interface, eliminating OutputDevice (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing guidou's comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/audio_renderer_mixer_manager_unittest.cc ('K') | « media/audio/null_audio_sink.cc ('k') | media/base/audio_renderer_mixer.h » ('j') | media/base/audio_renderer_mixer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/BUILD.gn

diff --git a/media/base/BUILD.gn b/media/base/BUILD.gn

index 21f5449811c645f5a0ae137bdcb977ad74e6d664..028f5713ca440e0b5cfddf543e185c22cc8d6625 100644

--- a/media/base/BUILD.gn

+++ b/media/base/BUILD.gn

@@ -153,7 +153,8 @@ source_set("base") {

"multi_channel_resampler.h",

"null_video_sink.cc",

"null_video_sink.h",

- "output_device.h",

+ "output_device_info.cc",

+ "output_device_info.h",

"pipeline.h",

"pipeline_impl.cc",

"pipeline_impl.h",

@@ -356,8 +357,6 @@ source_set("test_support") {

"fake_demuxer_stream.h",

"fake_media_resources.cc",

"fake_media_resources.h",

- "fake_output_device.cc",

- "fake_output_device.h",

"fake_text_track_stream.cc",

"fake_text_track_stream.h",

"gmock_callback_support.h",