Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: media/audio/audio_output_device.cc

Issue 1809093003: Moving SwitchOutputDevice out of OutputDevice interface, eliminating OutputDevice (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing guidou's comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_device.cc
diff --git a/media/audio/audio_output_device.cc b/media/audio/audio_output_device.cc
index 7044e9ae770649c0477b9b37af56eca6fff01abb..1468123ac4510765a53fa0547480de1ab40a483e 100644
--- a/media/audio/audio_output_device.cc
+++ b/media/audio/audio_output_device.cc
@@ -138,27 +138,10 @@ bool AudioOutputDevice::SetVolume(double volume) {
return true;
}
-OutputDevice* AudioOutputDevice::GetOutputDevice() {
- return this;
-}
-
-void AudioOutputDevice::SwitchOutputDevice(
- const std::string& device_id,
- const url::Origin& security_origin,
- const SwitchOutputDeviceCB& callback) {
- NOTREACHED();
-}
-
-AudioParameters AudioOutputDevice::GetOutputParameters() {
- CHECK(!task_runner()->BelongsToCurrentThread());
- did_receive_auth_.Wait();
- return output_params_;
-}
-
-OutputDeviceStatus AudioOutputDevice::GetDeviceStatus() {
+OutputDeviceInfo AudioOutputDevice::GetOutputDeviceInfo() {
CHECK(!task_runner()->BelongsToCurrentThread());
did_receive_auth_.Wait();
- return device_status_;
+ return OutputDeviceInfo(device_id_, device_status_, output_params_);
}
void AudioOutputDevice::RequestDeviceAuthorizationOnIOThread() {

Powered by Google App Engine
This is Rietveld 408576698