Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1809093002: Remove unnecessary overrides from CustomFakeGCMDriver (Closed)

Created:
4 years, 9 months ago by johnme
Modified:
4 years, 9 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary overrides from CustomFakeGCMDriver BUG=none Committed: https://crrev.com/a5be5aa5ef85bd78b30973e310072780c5493126 Cr-Commit-Position: refs/heads/master@{#381719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M components/gcm_driver/gcm_account_mapper_unittest.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
johnme
4 years, 9 months ago (2016-03-17 14:47:39 UTC) #2
Peter Beverloo
lgtm
4 years, 9 months ago (2016-03-17 14:54:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1809093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1809093002/1
4 years, 9 months ago (2016-03-17 14:54:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 15:44:42 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 15:47:07 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a5be5aa5ef85bd78b30973e310072780c5493126
Cr-Commit-Position: refs/heads/master@{#381719}

Powered by Google App Engine
This is Rietveld 408576698