Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: components/gcm_driver/gcm_account_mapper_unittest.cc

Issue 1809093002: Remove unnecessary overrides from CustomFakeGCMDriver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_account_mapper_unittest.cc
diff --git a/components/gcm_driver/gcm_account_mapper_unittest.cc b/components/gcm_driver/gcm_account_mapper_unittest.cc
index 4f8f4fa32eb473d8b072b3535d796d551fe0505c..a617d6c348e37081799cffce568046845493f958 100644
--- a/components/gcm_driver/gcm_account_mapper_unittest.cc
+++ b/components/gcm_driver/gcm_account_mapper_unittest.cc
@@ -94,9 +94,6 @@ class CustomFakeGCMDriver : public FakeGCMDriver {
// GCMDriver implementation:
void UpdateAccountMapping(const AccountMapping& account_mapping) override;
void RemoveAccountMapping(const std::string& account_id) override;
- void AddAppHandler(const std::string& app_id,
- GCMAppHandler* handler) override;
- void RemoveAppHandler(const std::string& app_id) override;
void RegisterImpl(const std::string& app_id,
const std::vector<std::string>& sender_ids) override;
@@ -158,15 +155,6 @@ void CustomFakeGCMDriver::RemoveAccountMapping(const std::string& account_id) {
last_removed_account_id_ = account_id;
}
-void CustomFakeGCMDriver::AddAppHandler(const std::string& app_id,
- GCMAppHandler* handler) {
- GCMDriver::AddAppHandler(app_id, handler);
-}
-
-void CustomFakeGCMDriver::RemoveAppHandler(const std::string& app_id) {
- GCMDriver::RemoveAppHandler(app_id);
-}
-
void CustomFakeGCMDriver::RegisterImpl(
const std::string& app_id,
const std::vector<std::string>& sender_ids) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698