Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1808943002: Remove unnecessary explicit keyword in ExclusiveAccessBubble class (Closed)

Created:
4 years, 9 months ago by joone
Modified:
4 years, 9 months ago
Reviewers:
scheib, miu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary explicit keyword in ExclusiveAccessBubble class BUG=none Committed: https://crrev.com/c847e222ae0f59ace649e08c6aac001e18c37be1 Cr-Commit-Position: refs/heads/master@{#381654}

Patch Set 1 #

Patch Set 2 : Update style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/exclusive_access/exclusive_access_bubble.h View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
joone
Please take a look at the CL.
4 years, 9 months ago (2016-03-16 23:40:05 UTC) #2
joone
4 years, 9 months ago (2016-03-16 23:41:07 UTC) #4
scheib
Please run `git cl format`, or format whitespace to styleguide manually. https://google.github.io/styleguide/cppguide.html
4 years, 9 months ago (2016-03-16 23:48:10 UTC) #5
joone
On 2016/03/16 23:48:10, scheib wrote: > Please run `git cl format`, or format whitespace to ...
4 years, 9 months ago (2016-03-17 00:34:52 UTC) #6
scheib
LGTM
4 years, 9 months ago (2016-03-17 02:30:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808943002/20001
4 years, 9 months ago (2016-03-17 03:16:55 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 03:22:43 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 03:24:06 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c847e222ae0f59ace649e08c6aac001e18c37be1
Cr-Commit-Position: refs/heads/master@{#381654}

Powered by Google App Engine
This is Rietveld 408576698