Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 180893004: Adjust both x and y position when drawing glyphs (Closed)

Created:
6 years, 9 months ago by eae
Modified:
6 years, 9 months ago
Reviewers:
dglazkov, behdad
CC:
blink-reviews, jamesr, krit, jbroman, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, fs, danakj, ed+blinkwatch_opera.com, Rik, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Adjust both x and y position when drawing glyphs Change GlyphBuffer::advanceAt to return a FloatSize with both the x and y advances. Change Font::drawGlyphBuffer to use the y advance, in addition to the x advance, when adjusting the startPoint for drawing glyphs. R=dglazkov@chromium.org BUG=247103 TEST=fast/text/international/vertical-positioning-with-combining-marks.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168670

Patch Set 1 #

Patch Set 2 : w/mac fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -12 lines) Patch
A LayoutTests/fast/text/international/vertical-positioning-with-combining-marks.html View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/international/vertical-positioning-with-combining-marks-expected.html View 1 chunk +28 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGTextRunRenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/Font.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/fonts/GlyphBuffer.h View 1 1 chunk +6 lines, -2 lines 0 comments Download
M Source/platform/fonts/WidthIterator.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M Source/platform/fonts/harfbuzz/FontHarfBuzz.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
eae
6 years, 9 months ago (2014-03-06 17:49:09 UTC) #1
dglazkov
Wow, so proud of myself. I think I actually understand this patch. That meeting with ...
6 years, 9 months ago (2014-03-06 18:46:00 UTC) #2
eae
Yay! On Thu, Mar 6, 2014 at 10:46 AM, <dglazkov@chromium.org> wrote: > Wow, so proud ...
6 years, 9 months ago (2014-03-06 18:46:46 UTC) #3
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-06 19:08:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/180893004/40001
6 years, 9 months ago (2014-03-06 19:08:37 UTC) #5
commit-bot: I haz the power
Change committed as 168670
6 years, 9 months ago (2014-03-06 19:41:06 UTC) #6
behdad
6 years, 9 months ago (2014-03-06 20:58:36 UTC) #7
Message was sent while issue was closed.
lgtm

Yay!

Powered by Google App Engine
This is Rietveld 408576698