Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 1808753002: Make consumeCustomIdent exclude css wide keywords (Closed)

Created:
4 years, 9 months ago by rwlbuis
Modified:
4 years, 9 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make consumeCustomIdent exclude css wide keywords According to the spec [1] "CSS-wide keywords are not valid <custom-ident>s", so move isCSSWideKeyword to CSSPropertyParserHelper and use it in consumeCustomIdent to exclude them. BUG=584999 [1] https://drafts.csswg.org/css-values-3/#identifier-value Committed: https://crrev.com/9a73681d0bc3c242838f5af0959ee4ab42c762c0 Cr-Commit-Position: refs/heads/master@{#381629}

Patch Set 1 #

Patch Set 2 : Add subtests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/animations/animations-parsing.html View 1 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/animations-parsing-expected.txt View 1 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
rwlbuis
PTAL, this originates from https://codereview.chromium.org/1798863005/.
4 years, 9 months ago (2016-03-16 17:03:01 UTC) #6
Timothy Loh
On 2016/03/16 17:03:01, rwlbuis wrote: > PTAL, this originates from https://codereview.chromium.org/1798863005/. lgtm
4 years, 9 months ago (2016-03-16 23:03:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808753002/20001
4 years, 9 months ago (2016-03-16 23:10:05 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 01:25:54 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 01:28:17 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a73681d0bc3c242838f5af0959ee4ab42c762c0
Cr-Commit-Position: refs/heads/master@{#381629}

Powered by Google App Engine
This is Rietveld 408576698