third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp - Issue 1808753002: Make consumeCustomIdent exclude css wide keywords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

Issue 1808753002: Make consumeCustomIdent exclude css wide keywords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add subtests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

index 4b6f86c2c930c33f2ab1747f154d24ee83b5fe1a..000b86604e2feef506bbc018bccfd8df71688ea1 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

@@ -288,7 +288,7 @@ PassRefPtrWillBeRawPtr<CSSPrimitiveValue> consumeIdentRange(CSSParserTokenRange&

PassRefPtrWillBeRawPtr<CSSCustomIdentValue> consumeCustomIdent(CSSParserTokenRange& range)

{

- if (range.peek().type() != IdentToken)

+ if (range.peek().type() != IdentToken || isCSSWideKeyword(range.peek().id()))

return nullptr;

return CSSCustomIdentValue::create(range.consumeIncludingWhitespace().value());

}

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h ('k') | no next file » | no next file with comments »