Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: ios/web/shell/BUILD.gn

Issue 1808733003: [iOS] Fix ios_web_shell to build with gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@components
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/ios/rules.gni ('K') | « build/config/ios/rules.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/shell/BUILD.gn
diff --git a/ios/web/shell/BUILD.gn b/ios/web/shell/BUILD.gn
index ab174d5444bf40a9923062788d14979cb71e7032..babef8a2e60f8ac9a8d7f61ad541b5590c77787e 100644
--- a/ios/web/shell/BUILD.gn
+++ b/ios/web/shell/BUILD.gn
@@ -24,17 +24,24 @@ app("ios_web_shell") {
"-Xlinker",
"2",
]
+}
+
+bundle_data_xib("main_view_bundle_data") {
+ visibility = [ ":shell" ]
+ source = "MainView.xib"
+}
- # TODO(crbug.com/546283): once gn supports bundle resources, add support for
- # the following gyp code:
- #
- # 'mac_bundle_resources': [
- # 'shell/Default.png',
- # 'shell/MainView.xib',
- # 'shell/textfield_background@2x.png',
- # 'shell/toolbar_back@2x.png',
- # 'shell/toolbar_forward@2x.png',
- # ],
+bundle_data("shell_bundle_data") {
+ visibility = [ ":shell" ]
+ sources = [
+ "Default.png",
+ "textfield_background@2x.png",
+ "toolbar_back@2x.png",
+ "toolbar_forward@2x.png",
+ ]
+ outputs = [
+ "{{bundle_resources_dir}}/{{source_file_part}}",
+ ]
}
source_set("shell") {
@@ -58,6 +65,8 @@ source_set("shell") {
]
deps = [
+ ":main_view_bundle_data",
+ ":shell_bundle_data",
"//base",
"//ios/web",
"//ios/web/public/app",
« build/config/ios/rules.gni ('K') | « build/config/ios/rules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698