Updates to gyp files for building Android.mk

Updates to gyp files for building Android.mk

Committed: http://code.google.com/p/skia/source/detail?r=13624

[djsollen, 2014-02-28 13:54:21]

https://codereview.chromium.org/180873012/diff/20001/gyp/opts.gyp
File gyp/opts.gyp (right):

https://codereview.chromium.org/180873012/diff/20001/gyp/opts.gyp#newcode119
gyp/opts.gyp:119: '-msse2',
is there any way to tell gyp to unset all the cflags so we don't have to keep a
master list?

[scroggo, 2014-02-28 14:17:20]

https://codereview.chromium.org/180873012/diff/20001/gyp/opts.gyp
File gyp/opts.gyp (right):

https://codereview.chromium.org/180873012/diff/20001/gyp/opts.gyp#newcode119
gyp/opts.gyp:119: '-msse2',
On 2014/02/28 13:54:21, djsollen wrote:
> is there any way to tell gyp to unset all the cflags so we don't have to keep
a
> master list?

I don't know how to tell gyp that, but I could do it in my generator.

That said, we DO want some of them. I could hard code into Android.mk the ones
we want, but I think it makes more sense to put them in the gyp files for a
couple of reasons:

When we want the same flags for the framework as otherwise, it makes sense to
keep them in the gyp files.

If/when we transition to GN, it would be nice to be able to use our existing gyp
files (modified obviously, but with basically the same information).

It also means the generator can be more general and we keep the specifics in
gyp.

[djsollen, 2014-02-28 14:24:36]

lgtm

[scroggo, 2014-02-28 14:59:09]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2014-02-28 14:59:12]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/scroggo@google.com/180873012/20001

[commit-bot: I haz the power, 2014-02-28 16:07:44]

Change committed as 13624